test: fix test-debugger-repl-break-in-module - #6686
Conversation
Sorry, something went wrong.
|
Fixes the issue for me. LGTM |
Sorry, something went wrong.
There was a problem hiding this comment.
Accidental change?
Sorry, something went wrong.
There was a problem hiding this comment.
Yes, accident, I'll fix it...
Sorry, something went wrong.
|
Is the plan to eventually move this test to test/parallel or test/sequential? |
Sorry, something went wrong.
|
@bnoordhuis I hadn't planned on moving them to sequential or parallel specifically, but just making sure that they get exercised in the test and test-ci tasks. Moving them to sequential is one way to do that, so that works for me. (I think parallel won't work unless we modify all the tests to use a custom port for the debugger.) |
Sorry, something went wrong.
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files.
|
Rebased, fixed accidental comment change, force pushed. |
Sorry, something went wrong.
|
LGTM
Agreed. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Two failures in CI are a known flaky test and a definitely-unrelated test that may also be flaky. Just to be cautious, re-running CI: https://ci.nodejs.org/job/node-test-pull-request/2625/ |
Sorry, something went wrong.
|
CI still looks good but with a pair of unrelated failures. More caution: https://ci.nodejs.org/job/node-test-pull-request/2626/ |
Sorry, something went wrong.
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: nodejs#6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Green that time. Landed in 9d445bc. |
Sorry, something went wrong.
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: #6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Checklist
Affected core subsystem(s)
test debugger
Description of change
The line number checks in test-debugger-repl-break-in-module were
checking for line numbers that exceed the total number of lines in the
files that were being inspected. Change the checks to match the actual
files.