FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: ensures consistent grammar in node.1 file by justshiv · Pull Request #6426 · nodejs/node · GitHub

/ node Public

doc: ensures consistent grammar in node.1 file - #6426

Closed
justshiv wants to merge 1 commit into
nodejs:masterfrom
justshiv:fix/man-grammar
ConversationCommits (1)ChecksFiles changed
Closed

doc: ensures consistent grammar in node.1 file#6426
justshiv wants to merge 1 commit into
nodejs:masterfrom
justshiv:fix/man-grammar

Conversation

justshiv commented Apr 27, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Grammar in node.1 file was inconsistent when starting man-page responses (Open vs Opens). I've changed this to ensure these responses are consistent throughout.

Trott added the doc Issues and PRs related to the documentations. label Apr 27, 2016

Trott commented Apr 27, 2016

Copy link
Copy Markdown
Member

@nodejs/documentation

Trott commented Apr 27, 2016

Copy link
Copy Markdown
Member

LGTM

Trott commented Apr 27, 2016

Copy link
Copy Markdown
Member

CI, just to be thorough: https://ci.nodejs.org/job/node-test-pull-request/2410/

thefourtheye commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott commented Apr 27, 2016

Copy link
Copy Markdown
Member

Only CI failure is a currently-problematic test on OS X, so CI is good.

Trott commented Apr 27, 2016

Copy link
Copy Markdown
Member

Should the commit message say ensure instead of ensures? Seems like an unnecessary nit to me, but maybe someone else thinks differently?

Fishrock123 commented Apr 27, 2016

Copy link
Copy Markdown
Contributor

LGTM. Commit would be better as ensure, but we can fix that when landing.

justshiv commented Apr 28, 2016

Copy link
Copy Markdown
Contributor Author

Ah sorry, the convention in my org is to use third person present verbs 😄

Fishrock123 commented Apr 29, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

@justshiv Btw, git thinks your name is justshiv

If you're ok with that, I'll land this as-is.

But if you'd like you can set your name to git by doing:

$ git config --global user.name "whatever you want to be known as"

and then git commit --amend --reset-author

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 2, 2016
doc: ensure consistent grammar in node.1 file
8ebec08 
PR-URL: nodejs#6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Fishrock123 commented May 2, 2016

Copy link
Copy Markdown
Contributor

Thanks, landed in 8ebec08

We can always .mailmap your name later. :)

Fishrock123 closed this May 2, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
doc: ensure consistent grammar in node.1 file
7c30f15 
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced May 4, 2016
Closed
Merged
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
doc: ensure consistent grammar in node.1 file
b3338eb 
PR-URL: nodejs#6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
doc: ensure consistent grammar in node.1 file
79735d1 
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins commented Jun 2, 2016

Copy link
Copy Markdown
Contributor

oh hey @justshiv !!! so happy to see you got something into core

MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
doc: ensure consistent grammar in node.1 file
18ecc77 
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
doc: ensure consistent grammar in node.1 file
7146066 
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL