crypto: split OpenSSL 3, BoringSSL, and legacy backends by panva · Pull Request #64211 · nodejs/node · GitHub

This separates the native crypto backend paths for OpenSSL >= 3, BoringSSL, and legacy OpenSSL. The OpenSSL >= 3 path now builds with OPENSSL_API_COMPAT=30000 and OPENSSL_NO_DEPRECATED, moving normal crypto/TLS code away from APIs that OpenSSL 3.0.0 marks deprecated. BoringSSL remains on its own branch, and OpenSSL < 3 remains the legacy fallback.

The exception is ENGINE support. ENGINE APIs are isolated into a dedicated compatibility target so they can remain available while the JS-facing engine APIs are runtime-deprecated in 27.x. That gives us a clear removal point for 28.x, without letting ENGINE usage leak back into the strict OpenSSL 3 path.

The split also makes the eventual OpenSSL 1.1.1 removal easier to reason about. Once support for OpenSSL < 3 is dropped, the legacy branch can be removed in a focused follow-up, possibly targeting 27.x, instead of untangling mixed version guards throughout the crypto implementation.

No public crypto or TLS API behavior is intentionally changed.

Assisted-by: Codex:gpt-5

Refs: #56733

Idea would be to land this for 26.x
Follow up dropping the legacy OpenSSL < 3 branch for 27.x
Follow up with EOL for the ENGINEs part for 28.x (DEP0183, crypto,https,tls: runtime-deprecate OpenSSL engine-based APIs (DEP0183) #63966)

Review requested:

@nodejs/crypto
@nodejs/gyp
@nodejs/security-wg
@nodejs/startup

Changes pass locally with linked OpenSSL 1.1.1, 3.0, 3.5, 4.0, and BoringSSL. Let's see what GHA and CI comes back with.

This separates the native crypto backend paths for OpenSSL >= 3, BoringSSL, and legacy OpenSSL. The OpenSSL >= 3 path now builds with `OPENSSL_API_COMPAT=30000` and `OPENSSL_NO_DEPRECATED`, moving normal crypto/TLS code away from APIs that OpenSSL 3.0.0 marks deprecated. BoringSSL remains on its own branch, and OpenSSL < 3 remains the legacy fallback. The exception is ENGINE support. ENGINE APIs are isolated into a dedicated compatibility target so they can remain available while the JS-facing engine APIs are runtime-deprecated in 27.x. That gives us a clear removal point for 28.x, without letting ENGINE usage leak back into the strict OpenSSL 3 path. The split also makes the eventual OpenSSL 1.1.1 removal easier to reason about. Once support for OpenSSL < 3 is dropped, the legacy branch can be removed in a focused follow-up, possibly targeting 27.x, instead of untangling mixed version guards throughout the crypto implementation. No public crypto or TLS API behavior is intentionally changed. Assisted-by: Codex:gpt-5 Signed-off-by: Filip Skokan <panva.ip@gmail.com>

CI: https://ci.nodejs.org/job/node-test-pull-request/74513/

ping @nodejs/crypto @nodejs/gyp @nodejs/security-wg

lgtm

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This separates the native crypto backend paths for OpenSSL >= 3, BoringSSL, and legacy OpenSSL. The OpenSSL >= 3 path now builds with `OPENSSL_API_COMPAT=30000` and `OPENSSL_NO_DEPRECATED`, moving normal crypto/TLS code away from APIs that OpenSSL 3.0.0 marks deprecated. BoringSSL remains on its own branch, and OpenSSL < 3 remains the legacy fallback. The exception is ENGINE support. ENGINE APIs are isolated into a dedicated compatibility target so they can remain available while the JS-facing engine APIs are runtime-deprecated in 27.x. That gives us a clear removal point for 28.x, without letting ENGINE usage leak back into the strict OpenSSL 3 path. The split also makes the eventual OpenSSL 1.1.1 removal easier to reason about. Once support for OpenSSL < 3 is dropped, the legacy branch can be removed in a focused follow-up, possibly targeting 27.x, instead of untangling mixed version guards throughout the crypto implementation. No public crypto or TLS API behavior is intentionally changed. Assisted-by: Codex:gpt-5 Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64211 Refs: #56733 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This separates the native crypto backend paths for OpenSSL >= 3, BoringSSL, and legacy OpenSSL. The OpenSSL >= 3 path now builds with `OPENSSL_API_COMPAT=30000` and `OPENSSL_NO_DEPRECATED`, moving normal crypto/TLS code away from APIs that OpenSSL 3.0.0 marks deprecated. BoringSSL remains on its own branch, and OpenSSL < 3 remains the legacy fallback. The exception is ENGINE support. ENGINE APIs are isolated into a dedicated compatibility target so they can remain available while the JS-facing engine APIs are runtime-deprecated in 27.x. That gives us a clear removal point for 28.x, without letting ENGINE usage leak back into the strict OpenSSL 3 path. The split also makes the eventual OpenSSL 1.1.1 removal easier to reason about. Once support for OpenSSL < 3 is dropped, the legacy branch can be removed in a focused follow-up, possibly targeting 27.x, instead of untangling mixed version guards throughout the crypto implementation. No public crypto or TLS API behavior is intentionally changed. Assisted-by: Codex:gpt-5 Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64211 Backport-PR-URL: #65087 Refs: #56733 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

panva requested review from jasnell, richardlau and tniessen June 30, 2026 08:54

panva added the wip Issues and PRs that are still a work in progress. label Jun 30, 2026

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 30, 2026

panva requested review from joyeecheung and targos June 30, 2026 08:56

panva force-pushed the separate-ncrypto-engines branch 2 times, most recently from 45975b9 to a277df2 Compare June 30, 2026 13:49

panva removed the wip Issues and PRs that are still a work in progress. label Jun 30, 2026

This comment was marked as outdated.

Sign in to view

panva added 6 commits July 2, 2026 09:32

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

207cd8f

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

fe19413

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

0e998d6

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

50789f4

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

ef00769

panva force-pushed the separate-ncrypto-engines branch from f695c61 to ef00769 Compare July 2, 2026 07:32

panva added 2 commits July 2, 2026 10:13

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

195951b

fixup! crypto: split OpenSSL 3, BoringSSL, and legacy backends

4d595d1

This comment was marked as outdated.

Sign in to view

panva added the review wanted PRs that need reviews. label Jul 2, 2026

mcollina approved these changes Jul 8, 2026

View reviewed changes

richardlau approved these changes Jul 8, 2026

View reviewed changes

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 8, 2026

panva mentioned this pull request Jul 8, 2026

crypto: support loading private keys through STORE loaders #63949

Merged

panva mentioned this pull request Jul 16, 2026

crypto: follow up on OpenSSL backend split #64547

Closed

panva mentioned this pull request Jul 21, 2026

[v26.x backport] crypto: split OpenSSL 3, BoringSSL, and legacy backends & followups #64657

Merged

panva added the backport-open-v26.x Indicate that the PR has an open backport label Jul 21, 2026

panva mentioned this pull request Jul 27, 2026

crypto,build: require OpenSSL 3, drop the bundled FIPS provider build #64777

Draft

aduh95 mentioned this pull request Jul 30, 2026

2026-07-22, Version 26.6.0 (Current) #64655

Merged

panva added backported-to-v26.x PRs backported to the v26.x-staging branch. and removed backport-open-v26.x Indicate that the PR has an open backport labels Aug 3, 2026

panva mentioned this pull request Aug 6, 2026

[v24.x backport] backend split, KT12 limit, ByteSource MemoryRetainer + fixes and improvements #65087

Closed

27 tasks

panva added the backport-open-v24.x Indicate that the PR has an open backport label Aug 6, 2026

github-actions Bot mentioned this pull request Aug 21, 2026

2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461

Open

crypto: split OpenSSL 3, BoringSSL, and legacy backends by panva · Pull Request #64211 · nodejs/node · GitHub

Uh oh!

Uh oh!

crypto: split OpenSSL 3, BoringSSL, and legacy backends - #64211

crypto: split OpenSSL 3, BoringSSL, and legacy backends#64211
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
panva:separate-ncrypto-engines

panva commented Jun 30, 2026 •
edited
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 30, 2026

Uh oh!

panva commented Jun 30, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jul 2, 2026

Uh oh!

panva commented Jul 7, 2026

Uh oh!

mcollina left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

crypto: split OpenSSL 3, BoringSSL, and legacy backends by panva · Pull Request #64211 · nodejs/node · GitHub

Uh oh!

Uh oh!

crypto: split OpenSSL 3, BoringSSL, and legacy backends - #64211

crypto: split OpenSSL 3, BoringSSL, and legacy backends#64211nodejs-github-bot merged 8 commits intonodejs:mainnodejs/node:mainfrom panva:separate-ncrypto-enginespanva/node:separate-ncrypto-enginesCopy head branch name to clipboard

Conversation

panva commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 30, 2026

Uh oh!

panva commented Jun 30, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jul 2, 2026

Uh oh!

panva commented Jul 7, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

crypto: split OpenSSL 3, BoringSSL, and legacy backends#64211
nodejs-github-bot merged 8 commits into
nodejs:mainfrom
panva:separate-ncrypto-engines

panva commented Jun 30, 2026 •
edited
Loading