crypto: follow up on OpenSSL backend split by panva · Pull Request #64547 · nodejs/node · GitHub

This follows up on #64211, which separated the OpenSSL >= 3, BoringSSL, and legacy OpenSSL backend paths.

It addresses issues identified during a subsequent review of that split (done with GPT-5.6 Sol). The changes restore unintentionally altered legacy behavior, improve handling of provider-backed keys, and ensure temporary private key material is cleansed appropriately.

Refs: #64211

Details

crypto: retain legacy DH validation

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before.

crypto: handle incomplete RSA private keys

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails.

crypto: cleanse provider private key copies

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output.

crypto: preserve RSA-PSS legacy pubkey DER

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs.

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (a27fe21) to head (74bb180).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_rsa.cc	66.66%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #64547      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         739      739              
  Lines      241698   241699       +1     
  Branches    45556    45552       -4     
==========================================
- Hits       218129   218119      -10     
- Misses      15103    15107       +4     
- Partials     8466     8473       +7

Files with missing lines	Coverage Δ
src/crypto/crypto_dh.cc	67.16% <ø> (ø)
src/crypto/crypto_rsa.cc	64.11% <66.66%> (+0.05%)	⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cc @nodejs/crypto

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

CI: https://ci.nodejs.org/job/node-test-pull-request/74878/

Landed in cecfdce...0938489

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Treat missing private RSA parameters as an export failure instead of passing null BIGNUM pointers to the JWK encoder. Also stop constructing a usable RSA view when reading an optional parameter itself fails. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #64547 Backport-PR-URL: #65087 Refs: #64211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

panva added crypto Issues and PRs related to the crypto subsystem. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jul 16, 2026

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 17, 2026

panva requested review from jasnell and richardlau July 17, 2026 06:19

panva force-pushed the followup-crypto-split branch from ecd623a to c5e29e7 Compare July 17, 2026 09:04

panva added 3 commits July 17, 2026 12:39

crypto: retain legacy DH validation

88d4e12

Limit the g >= p rejection needed by the provider backend to OpenSSL 3. Preserve the legacy DiffieHellman object and expose the validation result through verifyError as before. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

crypto: cleanse provider private key copies

b70e12f

Clear provider-exported RSA, EC, and DH private BIGNUMs before freeing them. Also cleanse OSSL_PARAM builder copies and the plaintext DER intermediate used for encrypted traditional PEM output. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

panva force-pushed the followup-crypto-split branch from c5e29e7 to 32c32b8 Compare July 17, 2026 10:39

crypto: preserve RSA-PSS legacy pubkey DER

74bb180

Recreate the historical rsaEncryption AlgorithmIdentifier used by X509Certificate legacy pubkey output for restricted and unrestricted RSA-PSS keys without relying on deprecated RSA APIs. Signed-off-by: Filip Skokan <panva.ip@gmail.com>

panva force-pushed the followup-crypto-split branch from 32c32b8 to 74bb180 Compare July 17, 2026 11:39

This comment was marked as outdated.

Sign in to view

jasnell approved these changes Jul 19, 2026

View reviewed changes

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 19, 2026

anonrig approved these changes Jul 21, 2026

View reviewed changes

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 21, 2026

nodejs-github-bot closed this Jul 21, 2026

panva deleted the followup-crypto-split branch July 21, 2026 15:49

panva mentioned this pull request Jul 21, 2026

[v26.x backport] crypto: split OpenSSL 3, BoringSSL, and legacy backends & followups #64657

Merged

panva added the backport-open-v26.x Indicate that the PR has an open backport label Jul 21, 2026

aduh95 mentioned this pull request Jul 30, 2026

2026-07-22, Version 26.6.0 (Current) #64655

Merged

panva added backported-to-v26.x PRs backported to the v26.x-staging branch. and removed backport-open-v26.x Indicate that the PR has an open backport labels Aug 3, 2026

panva mentioned this pull request Aug 6, 2026

[v24.x backport] backend split, KT12 limit, ByteSource MemoryRetainer + fixes and improvements #65087

Closed

27 tasks

panva added the backport-open-v24.x Indicate that the PR has an open backport label Aug 6, 2026

github-actions Bot mentioned this pull request Aug 21, 2026

2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461

Open

crypto: follow up on OpenSSL backend split by panva · Pull Request #64547 · nodejs/node · GitHub

Uh oh!

Uh oh!

crypto: follow up on OpenSSL backend split - #64547

crypto: follow up on OpenSSL backend split#64547
panva wants to merge 4 commits into
nodejs:mainfrom
panva:followup-crypto-split

panva commented Jul 16, 2026 •
edited
Loading

Uh oh!

Uh oh!

codecov Bot commented Jul 17, 2026 •
edited
Loading

Uh oh!

Uh oh!

panva commented Jul 17, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jul 18, 2026

Uh oh!

nodejs-github-bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

crypto: follow up on OpenSSL backend split by panva · Pull Request #64547 · nodejs/node · GitHub

Uh oh!

Uh oh!

crypto: follow up on OpenSSL backend split - #64547

crypto: follow up on OpenSSL backend split#64547panva wants to merge 4 commits intonodejs:mainnodejs/node:mainfrom panva:followup-crypto-splitpanva/node:followup-crypto-splitCopy head branch name to clipboard

Conversation

panva commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

panva commented Jul 17, 2026

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Jul 18, 2026

Uh oh!

nodejs-github-bot commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

crypto: follow up on OpenSSL backend split#64547
panva wants to merge 4 commits into
nodejs:mainfrom
panva:followup-crypto-split

panva commented Jul 16, 2026 •
edited
Loading

codecov Bot commented Jul 17, 2026 •
edited
Loading