tools: skip early single-approval PRs in commit queue - #64262
Conversation
Sorry, something went wrong.
Filter regular commit-queue PRs in the workflow so PRs with only one approval are skipped until they have been open for 7 days. Keep the fast-track path unchanged and update the commit-queue documentation to match the workflow behavior. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
|
Review requested:
|
Sorry, something went wrong.
aduh95
left a comment
There was a problem hiding this comment.
Really not a fan of the added complexity, and we've learned the hard way that commit date was not a reliable info. I'd much prefer using a different label (maybe slow-track?) which the bot would add if the first attempt at the CQ failed
Sorry, something went wrong.
panva
left a comment
There was a problem hiding this comment.
Sorry, something went wrong.
|
I think we should make this change for ease of maintenance. Most of my PRs get a single approval. Even though they're author-ready and CI is green, I have to wait for 7 days before adding the commit-queue label. I sometimes forget it and PRs stay unmerged. I've seen 3-4 occurrences where another collaborator added the commit-queue label with knowing that there are no two approvals. The commit queue workflow adds commit-queue-failed in that case. This can be avoided if we just not process the PRs which are not ready to land, which is a proposal in this PR. |
Sorry, something went wrong.
|
Could someone please approve nodejs/node-auto-test#45? I'm testing my label idea |
Sorry, something went wrong.
Sorry, something went wrong.
Filter regular commit-queue PRs in the workflow so PRs with only one
valid approval are skipped until they have been open for at least 7 days.
Keep fast-track PR handling unchanged.
Today, commit-queue can pick up a regular PR that is still not eligible to
land, and the failure only happens later inside git node land.
For example, in #64163 (comment), the PR had a single approval
and commit-queue was added before the PR had been open for 7 days.
The queue then failed during landing instead of simply skipping that PR
until it became eligible.
Refs: #64163 (comment)
Assisted-by: openai:gpt-5.5