| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
And make the CQ use it to support adding the label on PRs with a single approval which are not 7 days old yet. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Review requested:
|
Sorry, something went wrong.
Can we aleviate this drawback? Often times a PR that's ready to land in the 2-7 period would get an approval with a nit, or just requests a small change before approving, you want to fix that nit but now can't land it with CQ even if the one who requested a small change re-approves because now it needs one more existing reviewer to either come back and approve or someone else entirely. #62498 OTOH just allowed to add the CQ label with one approval and it'd stay in the queue until a 2nd review comes or 7 days pass. No brain teasers. |
Sorry, something went wrong.
|
@panva you can add the
Approvals: 2+
PRs that have anough approvals to land before the 7 days mark
label manually |
Sorry, something went wrong.
Which label would that be? Can you explain this automation proposal here better? |
Sorry, something went wrong.
|
The automation runs every time a review is submitted or dismissed. It will count how many approvals from the team (TSC for semver-major PRs, collaborators for other PRs) on the HEAD (i.e. since the last non-empty commit), if that's more that 2 and there are no changes requested, it adds
Approvals: 2+
PRs that have anough approvals to land before the 7 days mark
, otherwise it removes it.
To answer this specifically, the answer is: definitely yes, I had to add some logic to check if the review was on the last commit. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
And make the CQ use it to support adding the label on PRs with a single approval which are not 7 days old yet.
I've tested it with nodejs/node-auto-test#45, seems to be working fine. Here are a few caveats:
Alternative to #64262 and #62498