FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: don't throw when destroying socket proxy by mcollina · Pull Request #64427 · nodejs/node · GitHub

/ node Public

http2: don't throw when destroying socket proxy - #64427

Closed
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:http2-socket-proxy-destroy
ConversationCommits (1)ChecksFiles changed
Closed

http2: don't throw when destroying socket proxy#64427
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:http2-socket-proxy-destroy

Conversation

mcollina commented Jul 11, 2026

Copy link
Copy Markdown
Member

Calling destroy() on the http2session.socket proxy now destroys the session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION, matching the streams contract that destroy() never throws (root cause behind nodejs/undici#5525).

nodejs-github-bot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jul 11, 2026
http2: don't throw when destroying socket proxy
fa57b72 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina force-pushed the http2-socket-proxy-destroy branch from 27433a8 to fa57b72 Compare July 11, 2026 16:03
mcollina mentioned this pull request Jul 11, 2026
Merged

codecov Bot commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (8a3b11c) to head (fa57b72).
⚠️ Report is 58 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #64427   +/-   ##
=======================================
  Coverage   90.24%   90.25%           
=======================================
  Files         741      741           
  Lines      241384   241384           
  Branches    45480    45484    +4     
=======================================
+ Hits       217844   217851    +7     
+ Misses      15097    15088    -9     
- Partials     8443     8445    +2
Files with missing lines Coverage Δ
lib/internal/http2/core.js 94.81% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trivikr approved these changes Jul 11, 2026
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mertcanaltin approved these changes Jul 11, 2026
View reviewed changes

mertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jul 12, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2026

nodejs-github-bot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74746/

nodejs-github-bot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74772/

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 13, 2026

nodejs-github-bot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74784/

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 17, 2026
mcollina added a commit that referenced this pull request Jul 18, 2026
http2: don't throw when destroying socket proxy
fb5d01f 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mcollina commented Jul 18, 2026

Copy link
Copy Markdown
Member Author

Landed in fb5d01f

mcollina closed this Jul 18, 2026
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
http2: don't throw when destroying socket proxy
81284a0 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Jul 21, 2026
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
http2: don't throw when destroying socket proxy
86f7c86 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
http2: don't throw when destroying socket proxy
7bfcd28 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
pimterry mentioned this pull request Jul 22, 2026
Merged
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
http2: don't throw when destroying socket proxy
4d48984 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
http2: don't throw when destroying socket proxy
b075b33 
Calling destroy() on the http2session.socket proxy now destroys the
session instead of throwing ERR_HTTP2_NO_SOCKET_MANIPULATION.

Refs: nodejs/undici#5525
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #64427
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request Aug 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
ronag ronag approved these changes
trivikr trivikr approved these changes
+3 more reviewers
efekrskl efekrskl approved these changes
mertcanaltin mertcanaltin approved these changes
bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL