test: fix flaky http2 socket proxy destroy test - #64673
Merged
nodejs-github-bot merged 1 commit intoJul 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Tim Perry <pimterry@gmail.com>
mcollina
approved these changes
Jul 22, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
good catch
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @mcollina. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Jul 22, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 30, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #64673 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #64673 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a flaky test (failing yesterday) introduced recently in #64427.
This is effectively two tests running in parallel against a single server. The second test shuts down the server when it finishes, assuming that this means everything is done, but if the first test runs slowly it may not complete before that happens.
Adding a setTimeout manually around the first test block to simulate this recreates the same error as in CI.
Nice easy fix: use a Countdown to wait for both tests before closing the server, so there's no interdependency.