build: extract temporal_capi crate directory name into gyp variable - #64482
Merged
nodejs-github-bot merged 1 commit intoJul 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This is a no-op for current builds, but will allow the crate updater in node-core-utils to update the include path with the new crate location, as the crate directory names will include a version string. Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
approved these changes
Jul 14, 2026
targos
approved these changes
Jul 14, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Jul 15, 2026
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
This is a no-op for current builds, but will allow the crate updater in node-core-utils to update the include path with the new crate location, as the crate directory names will include a version string. Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64482 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
This is a no-op for current builds, but will allow the crate updater in node-core-utils to update the include path with the new crate location, as the crate directory names will include a version string. Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64482 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
This is a no-op for current builds, but will allow the crate updater in node-core-utils to update the include path with the new crate location, as the crate directory names will include a version string. Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64482 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a no-op for current builds, but will allow the crate updater (nodejs/node-core-utils#1117) to update the include path with the new crate location, as the crate directory names will include a version string.