feat(v8)!: synchronize Rust crates with major updates by Renegade334 · Pull Request #1117 · nodejs/node-core-utils · GitHub

An implementation of nodejs/node#64191 (comment). Depends on #1116 and nodejs/node#64482.

Broadly speaking, the process is as follows:

Checkout the third_party/rust repository alongside the other DEPS. Note that this never enters the Node.js git tree, as it's deliberately not exempt from .gitignore, but fetching it here can make use of the existing DEPS machinery.
Use cargo tree to walk the temporal_capi dependency tree in third_party/rust/chromium_crates_io, and populate a list of transitive dependencies, so that we only vendor what we need for Temporal.
Build a new Cargo.toml manifest, copying any custom configs for crates that appear in the temporal_capi dependency tree.
Copy the vendored dependencies from third_party/rust/chromium_crates_io to deps/crates.
- We don't use cargo vendor here, because Chromium uses its own gnrt toolchain to vendor its crate dependencies, which also applies any floating patches in third_party/rust/chromium_crates_io/patches. Using cargo vendor would fetch fresh copies from crates.io, and miss these patches.
- The slight caveat is that, unlike cargo vendor, gnrt always adds some variation of the version string when naming the vendored crate directories. It doesn't matter for the rust build, since cargo doesn't care about the directory names, but it does mean that we need to update the temporal_capi include path in crates.gyp whenver we update the crates.
Regenerate the lockfile.
Update a standalone variable in crates.gyp containing the temporal_capi crate directory name, so that the V8 C++ build has the correct include path for the temporal_rs headers.
🏁

Like Chromium, this approach doesn't add a rust-version to the crates manifest; Cargo will read this from the dependencies' manifests anyway. However, while it's not necessary for the build, I appreciate that it may be useful to see if our Rust requirement has changed, for updating BUILDING.md etc. If desired, we can either add this field or output the MSRV to terminal somehow; it'd just require interrogating each dependency's Cargo.toml while walking the tree.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.06%. Comparing base (09c8ff9) to head (c5892a8).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1117   +/-   ##
=======================================
  Coverage   63.06%   63.06%           
=======================================
  Files          50       50           
  Lines        8288     8288           
=======================================
  Hits         5227     5227           
  Misses       3061     3061

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Is this ready for review?

This is a breaking change, as Cargo is now a mandatory requirement for running a major update.

If you have any comments on the overall approach then fire away, but I'll mark as ready for review once the associated core PR is merged, so that people can do proper test runs.

Like Chromium, this approach doesn't add a rust-version to the crates manifest; Cargo will read this from the dependencies' manifests anyway. However, while it's not necessary for the build, I appreciate that it may be useful to see if our Rust requirement has changed, for updating BUILDING.md etc. If desired, we can either add this field or output the MSRV to terminal somehow; it'd just require interrogating each dependency's Cargo.toml while walking the tree.

This wasn't actually much effort to implement, so I've added this in.

New example run: nodejs/node@2c67a51

If you have any comments on the overall approach then fire away, but I'll mark as ready for review once the associated core PR is merged, so that people can do proper test runs.

FWIW having the other PR merged is not necessary for doing test runs, one can apply the patch on nodejs/node already. I'd like this PR to land soon so we can release 7.0.0 which is long overdue at this point (but since this is marked semver major, it makes sense to wait for it)

The upstream gyp PR has landed, so should be easy to test out on main.

I've drafted an update PR at nodejs/node#64543 so that the output can be checked with a CI run on different platforms.

Thank you!

Suggested change

      
                    ['tree', '-Z', 'bindeps', '--package', 'temporal_capi', '--prefix', 'none'],
          
                    ['+nightly', 'tree', '-Z', 'bindeps', '--package', 'temporal_capi', '--prefix', 'none'],

Should we add this change? Without it, this command fails on my computer with:

➤ cargo tree -Z bindeps --package temporal_capi --prefix none
error: the `-Z` flag is only accepted on the nightly channel of Cargo, but this is the `stable` channel
See https://doc.rust-lang.org/book/appendix-07-nightly-rust.html for more information about Rust release channels.

Looks like Chromium sets RUSTC_BOOTSTRAP=1 in its toolchain, does this work with your setup?

The issue with +xyz is that it only works in a rustup environment.

I tested with this patch and it works too:

Index: lib/update-v8/updateCrates.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/lib/update-v8/updateCrates.js b/lib/update-v8/updateCrates.js
--- a/lib/update-v8/updateCrates.js	(revision c263c2ae7d9be82feb79766a89a7bdaf5527b86b)
+++ b/lib/update-v8/updateCrates.js	(date 1785233230153)
@@ -37,7 +37,12 @@
         {
           ignoreFailure: false,
           captureStdout: true,
-          spawnArgs: { cwd: path.join(ctx.nodeDir, chromiumCratesDir) }
+          spawnArgs: {
+            cwd: path.join(ctx.nodeDir, chromiumCratesDir), env: {
+              ...process.env,
+              RUSTC_BOOTSTRAP: '1'
+            }
+          }
         }
       );
       const crates = new Set();

Renegade334 mentioned this pull request Jul 14, 2026

build: extract temporal_capi crate directory name into gyp variable nodejs/node#64482

Merged

Renegade334 requested review from legendecas, richardlau and targos July 14, 2026 00:26

Renegade334 force-pushed the v8-crates branch from 7007980 to a743669 Compare July 14, 2026 01:00

targos approved these changes Jul 15, 2026

View reviewed changes

legendecas reviewed Jul 15, 2026

View reviewed changes

feat(v8)!: synchronize Rust crates with major updates

d1ec300

This is a breaking change, as Cargo is now a mandatory requirement for running a major update.

Renegade334 force-pushed the v8-crates branch from a743669 to d3beea5 Compare July 15, 2026 13:51

fixup! feat(v8)!: synchronize Rust crates with major updates

c5892a8

Renegade334 force-pushed the v8-crates branch from d3beea5 to c5892a8 Compare July 15, 2026 13:52

Renegade334 marked this pull request as ready for review July 15, 2026 13:55

Renegade334 mentioned this pull request Jul 16, 2026

deps: update temporal_rs to 0.2.3 nodejs/node#64543

Closed

legendecas approved these changes Jul 17, 2026

View reviewed changes

Renegade334 merged commit 78e1dbb into nodejs:main Jul 21, 2026
11 checks passed

Renegade334 deleted the v8-crates branch July 21, 2026 18:03

nodejs-github-bot mentioned this pull request Jul 21, 2026

chore(main): release 7.0.0 #1082

Merged

targos reviewed Jul 27, 2026

View reviewed changes

Renegade334 mentioned this pull request Jul 28, 2026

fix(v8): set RUSTC_BOOTSTRAP=1 when using Cargo nightly features #1127

Merged

+                  task: async(ctx) => {
+                    const tree = await forceRunAsync(
+                      ctx.cargo,
+                      ['tree', '-Z', 'bindeps', '--package', 'temporal_capi', '--prefix', 'none'],

feat(v8)!: synchronize Rust crates with major updates by Renegade334 · Pull Request #1117 · nodejs/node-core-utils · GitHub

Uh oh!

feat(v8)!: synchronize Rust crates with major updates - #1117

feat(v8)!: synchronize Rust crates with major updates#1117
Renegade334 merged 2 commits into
nodejs:mainfrom
Renegade334:v8-crates

Renegade334 commented Jul 14, 2026 •
edited
Loading

Uh oh!

Uh oh!

codecov Bot commented Jul 14, 2026 •
edited
Loading

Uh oh!

Uh oh!

legendecas left a comment

Uh oh!

Renegade334 commented Jul 15, 2026

Uh oh!

Renegade334 commented Jul 15, 2026

Uh oh!

aduh95 commented Jul 15, 2026

Uh oh!

Renegade334 commented Jul 16, 2026 •
edited
Loading

Uh oh!

Uh oh!

legendecas commented Jul 17, 2026

Uh oh!

Uh oh!

targos Jul 27, 2026

Uh oh!

Renegade334 Jul 27, 2026

Uh oh!

targos Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	['tree', '-Z', 'bindeps', '--package', 'temporal_capi', '--prefix', 'none'],
	['+nightly', 'tree', '-Z', 'bindeps', '--package', 'temporal_capi', '--prefix', 'none'],

feat(v8)!: synchronize Rust crates with major updates by Renegade334 · Pull Request #1117 · nodejs/node-core-utils · GitHub

Uh oh!

feat(v8)!: synchronize Rust crates with major updates - #1117

feat(v8)!: synchronize Rust crates with major updates#1117Renegade334 merged 2 commits intonodejs:mainnodejs/node-core-utils:mainfrom Renegade334:v8-cratesRenegade334/node-core-utils:v8-cratesCopy head branch name to clipboard

Conversation

Renegade334 commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

Renegade334 commented Jul 15, 2026

Uh oh!

Renegade334 commented Jul 15, 2026

Uh oh!

aduh95 commented Jul 15, 2026

Uh oh!

Renegade334 commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legendecas commented Jul 17, 2026

Uh oh!

Uh oh!

targos Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Renegade334 Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

targos Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat(v8)!: synchronize Rust crates with major updates#1117
Renegade334 merged 2 commits into
nodejs:mainfrom
Renegade334:v8-crates

Renegade334 commented Jul 14, 2026 •
edited
Loading

codecov Bot commented Jul 14, 2026 •
edited
Loading

Renegade334 commented Jul 16, 2026 •
edited
Loading