FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: store "default" OpenSSL version in `openssl-matrix.nix` by aduh95 · Pull Request #64962 · nodejs/node · GitHub

/ node Public

tools: store "default" OpenSSL version in openssl-matrix.nix - #64962

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:openssl-matrix-default
Aug 4, 2026
ConversationCommits (1)ChecksFiles changed
Merged

tools: store "default" OpenSSL version in openssl-matrix.nix#64962
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:openssl-matrix-default

Conversation

aduh95 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

To help with automating keeping in sync with the bundled version.

nodejs-github-bot commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 2, 2026
aduh95 mentioned this pull request Aug 2, 2026
Closed
panva previously approved these changes Aug 2, 2026
View reviewed changes
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 2, 2026

panva commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Actually, #63949 needs the 3.5 target to stay, its deps don't play nice with 4.0 yet to be able to use that instead.

panva dismissed their stale review August 2, 2026 16:30

Per above

aduh95 commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Actually, #63949 needs the 3.5 target to stay, its deps don't play nice with 4.0 yet to be able to use that instead.

This PR doesn't change that, the bundled version is OpenSSL 3.5:

node/deps/openssl/openssl/VERSION.dat

Lines 1 to 2 in c55eb4a

MAJOR=3
MINOR=5

node/tools/nix/openssl-matrix.nix

Lines 8 to 9 in 8ecffaf

# "default" OpenSSL release line, should be kept in sync with the bundled version:
openssl = pkgs.openssl_3_5;

panva commented Aug 2, 2026

Copy link
Copy Markdown
Member

Thank you.

tools: store "default" OpenSSL version in openssl-matrix.nix
166e844 
To help with automating keeping in sync with the bundled version.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 force-pushed the openssl-matrix-default branch from 8296ba0 to 166e844 Compare August 2, 2026 22:31

This comment was marked as off-topic.

Sign in to view

aduh95 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

#64962 (comment) is showing because #64967 is not yet merged

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 3, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2026
nodejs-github-bot merged commit 3390622 into nodejs:main Aug 4, 2026
40 checks passed

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Landed in 3390622

aduh95 deleted the openssl-matrix-default branch August 4, 2026 16:49

panva commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Actually, #63949 needs the 3.5 target to stay, its deps don't play nice with 4.0 yet to be able to use that instead.

This did indeed disable coverage for #63949 since matrix.openssl.attr is now openssl. I'll fix that with a startsWith on matrix.openssl.name in #64960

aduh95 mentioned this pull request Aug 4, 2026
Merged

aduh95 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Fix is in #65023

aduh95 mentioned this pull request Aug 9, 2026
Merged
aduh95 added a commit that referenced this pull request Aug 13, 2026
tools: store "default" OpenSSL version in openssl-matrix.nix
ae4b8df 
To help with automating keeping in sync with the bundled version.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64962
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 added a commit that referenced this pull request Aug 25, 2026
tools: store "default" OpenSSL version in openssl-matrix.nix
f0140d7 
To help with automating keeping in sync with the bundled version.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #64962
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL