FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add ./tools/nix/pkcs11.nix to nix-changes.yml by panva · Pull Request #64967 · nodejs/node · GitHub

/ node Public

tools: add ./tools/nix/pkcs11.nix to nix-changes.yml - #64967

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:tools-followup
Aug 4, 2026
Merged

tools: add ./tools/nix/pkcs11.nix to nix-changes.yml#64967
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:tools-followup

Conversation

panva commented Aug 2, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva requested a review from aduh95 August 2, 2026 20:22

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 2, 2026
panva added tools Issues and PRs related to the tools directory. and removed meta Issues and PRs related to the general management of the project. labels Aug 2, 2026
aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 2, 2026

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 3, 2026

panva commented Aug 3, 2026
edited
Loading

Copy link
Copy Markdown
Member Author

@bnb 👍 alone won't cut it, this also needs a second approval to be able to fast-track 🙏

aduh95 requested a review from cjihrig August 4, 2026 10:03
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2026
nodejs-github-bot merged commit 72768c7 into nodejs:main Aug 4, 2026
46 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 72768c7

panva deleted the tools-followup branch August 6, 2026 19:58
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64967
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL