test: use spawnSyncAndAssert in windowsHide test - #65351
Merged
nodejs-github-bot merged 1 commit intoAug 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Junsoo Ha <junsoo2018@naver.com>
aduh95
approved these changes
Aug 17, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65351 +/- ##
==========================================
- Coverage 90.13% 90.11% -0.02%
==========================================
Files 752 752
Lines 251820 251820
Branches 47352 47350 -2
==========================================
- Hits 226974 226934 -40
- Misses 16158 16229 +71
+ Partials 8688 8657 -31 see 52 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
Aug 17, 2026
This comment was marked as outdated.
jasnell
approved these changes
Aug 17, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
StefanStojanovic
approved these changes
Aug 18, 2026
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65351 ✔ Done loading data for nodejs/node/pull/65351 ----------------------------------- PR info ------------------------------------ Title test: use spawnSyncAndAssert in windowsHide test (#65351) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ganjanggejang:replace-spawnsync -> nodejs:main Labels test, author ready, needs-ci, commit-queue Commits 1 - test: use spawnSyncAndAssert in windowsHide test Committers 1 - Junsoo Ha <junsoo2018@naver.com> PR-URL: https://github.com/nodejs/node/pull/65351 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65351 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 17 Aug 2026 11:58:51 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/65351#pullrequestreview-4951952749 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65351#pullrequestreview-4953484636 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65351#pullrequestreview-4955316846 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/65351#pullrequestreview-4959345464 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-18T07:17:53Z: https://ci.nodejs.org/job/node-test-pull-request/75962/ - Querying data for job/node-test-pull-request/75962/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32251410497 |
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #65351 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #65351 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manual status, signal, stdout and stderr assertions with
spawnSyncAndAssert() from test/common/child_process.
The previous code asserted the status first, so a CI failure only
reported the exit status and the child's output was never shown. On
failure the helper prints stdout, stderr, status, signal and the
command that was run.
Only changed sync spawn(), because there is no async helper yet.