test: use common/child_process spawnSync helpers - #65377
Merged
nodejs-github-bot merged 1 commit intoAug 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Replace manual spawnSync() result assertions with test/common/child_process helper functions. Signed-off-by: Junsoo Ha <junsoo2018@naver.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65377 +/- ##
==========================================
+ Coverage 90.11% 90.13% +0.02%
==========================================
Files 752 752
Lines 251861 251861
Branches 47365 47362 -3
==========================================
+ Hits 226955 227011 +56
+ Misses 16238 16184 -54
+ Partials 8668 8666 -2 see 36 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
atlowChemi
approved these changes
Aug 18, 2026
lpinca
approved these changes
Aug 18, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Replace manual spawnSync() result assertions with test/common/child_process helper functions. Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #65377 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Replace manual spawnSync() result assertions with test/common/child_process helper functions. Signed-off-by: Junsoo Ha <junsoo2018@naver.com> PR-URL: #65377 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual spawnSync() result assertions with
spawnSyncAndExitWithoutError(), spawnSyncAndExit() and
spawnSyncAndAssert() from test/common/child_process.
This also removes hand-rolled if (status !== 0) console.log(...)
blocks that duplicate what the helpers already do, and adds a
signal check to call sites that previously only compared status.
Follow-up to #65351, applying the same change to the remaining sync spawn call sites.