test: use common spawnSync helpers in more tests - #65552
Conversation
Sorry, something went wrong.
The helpers report the command, both streams, and the exit condition on failure, so mismatches are diagnosed consistently across tests. Signed-off-by: greenhead <greenheadhq@gmail.com>
|
Review requested:
|
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #65552 +/- ##
==========================================
- Coverage 90.13% 90.07% -0.06%
==========================================
Files 751 751
Lines 253635 254075 +440
Branches 47786 47902 +116
==========================================
+ Hits 228615 228862 +247
- Misses 16268 16420 +152
- Partials 8752 8793 +41 see 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Sorry, something went wrong.
| { status: 9, signal: null }, | ||
| ); | ||
| assert.strictEqual(child.status, 9); | ||
| console.log(child.stderr); |
There was a problem hiding this comment.
nit: this is no longer necessary, the helper will output it in case of error
| console.log(child.stderr); |
Sorry, something went wrong.
There was a problem hiding this comment.
@aduh95 Thanks for the review!
I tried this locally and the test fails. This is a message test, so this console.log is what produces the output matched against node_run_list.out. The helper only prints on mismatch, and { status: 9, signal: null } is the expected result here.
Happy to update if I'm missing something!
Sorry, something went wrong.
Signed-off-by: greenhead <greenheadhq@gmail.com>
Reviewers
At least 1 approving review is required to merge this pull request.
Replaces manual spawnSync() result assertions with the test/common/child_process helpers in eight tests, following the same approach as #65377. Every existing expectation (status, signal, stream contents) is preserved, and the helpers report the command and both streams when a check fails.
This also adds a signal check at call sites that previously only compared status, matching the helper defaults.
Only success-path blocks whose assertions map one-to-one onto the helper defaults are converted. blocks that assert bespoke failure modes are left unchanged.
Refs: #65377