FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for punycode by firedfox · Pull Request #6805 · nodejs/node · GitHub

/ node Public

doc: add added: information for punycode - #6805

Closed
firedfox wants to merge 1 commit into
nodejs:masterfrom
firedfox:add-added-infomation-for-punycode
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: information for punycode#6805
firedfox wants to merge 1 commit into
nodejs:masterfrom
firedfox:add-added-infomation-for-punycode

Conversation

firedfox commented May 17, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 17, 2016
sam-github mentioned this pull request May 17, 2016
Closed
36 tasks

addaleax commented May 17, 2016

Copy link
Copy Markdown
Member

LGTM, thank you for the work here!

jasnell commented May 17, 2016

Copy link
Copy Markdown
Member

LGTM but I'd like @bnoordhuis to verify/doublecheck the versions on this one if possible

bnoordhuis reviewed May 18, 2016
View reviewed changes
Comment thread doc/api/punycode.md Outdated

bnoordhuis May 18, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

v0.6.1 actually. :-)

firedfox May 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@bnoordhuis You are right. I'll fix it right away. I was misled by the punycode doc.

[Punycode.js][] is bundled with Node.js v0.6.2+.

I'll fix it, too.

firedfox May 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@bnoordhuis All fixed. Thank you very much!

firedfox force-pushed the add-added-infomation-for-punycode branch from ac1906e to 11c71fe Compare May 18, 2016 18:10

firedfox commented May 18, 2016

Copy link
Copy Markdown
Contributor Author

Sorry for making so many mistakes. Obviously I should rely on binaries but not docs. I'm working on a script to check the versions by calling methods within all nodejs binaries, from v0.1.14 to v6.2.0.

bnoordhuis reviewed May 18, 2016
View reviewed changes
Comment thread doc/api/punycode.md Outdated

bnoordhuis May 18, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

So, this should be v0.5.1. The first punycode.js was https://github.com/bnoordhuis/punycode.js and was later replaced with https://github.com/bestiejs/punycode.js.

firedfox May 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's done! Thanks!

firedfox force-pushed the add-added-infomation-for-punycode branch from 11c71fe to edf1b4c Compare May 18, 2016 18:38

bnoordhuis commented May 19, 2016

Copy link
Copy Markdown
Member

Thanks Daniel, landed in b90c52e.

bnoordhuis closed this May 19, 2016
bnoordhuis pushed a commit that referenced this pull request May 19, 2016
doc: add added: information for punycode
b90c52e 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
doc: add added: information for punycode
ebf6c11 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
doc: add added: information for punycode
3b96609 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
doc: add added: information for punycode
08f1361 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
doc: add added: information for punycode
496cf8a 
PR-URL: nodejs#6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for punycode
52f1012 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for punycode
03131ef 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for punycode
0c25aa8 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for punycode
a870cdc 
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL