FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for stream by italoacasas · Pull Request #7287 · nodejs/node · GitHub

/ node Public

doc: add added: information for stream - #7287

Closed
italoacasas wants to merge 12 commits into
nodejs:masterfrom
italoacasas:docs/add-added-stream
ConversationCommits (12)ChecksFiles changed
Closed

doc: add added: information for stream#7287
italoacasas wants to merge 12 commits into
nodejs:masterfrom
italoacasas:docs/add-added-stream

Conversation

italoacasas commented Jun 13, 2016

Copy link
Copy Markdown
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for stream

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 13, 2016
italoacasas mentioned this pull request Jun 13, 2016
Closed
2 tasks
sam-github mentioned this pull request Jun 13, 2016
Closed
36 tasks
mscdex added the stream Issues and PRs related to the stream subsystem. label Jun 13, 2016

claudiorodriguez commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

Some minor things:

Other than that, the actual content of the PR LGTM
Thanks!

addaleax reviewed Jun 15, 2016
View reviewed changes
Comment thread doc/api/stream.md
#### Class: stream.Writable
<!-- YAML
added: v0.3.0
-->

addaleax Jun 15, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

0.9.4

italoacasas mentioned this pull request Jun 19, 2016
Closed

italoacasas commented Jun 19, 2016

Copy link
Copy Markdown
Author

Writable Streams section is done.

italoacasas commented Jun 21, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

Readable Streams section is done

addaleax reviewed Jun 23, 2016
View reviewed changes
Comment thread doc/api/stream.md
##### writable.end([chunk][, encoding][, callback])
<!-- YAML
added: v0.9.9
-->

addaleax Jun 23, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality 
$ nvm use 0.9.4
Now using node v0.9.4
$ node
> typeof require('stream').Writable.prototype.end
'function'

italoacasas Jun 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, but in 0.9.4 that method doesn't accept a callback

a9c4a20

addaleax Jun 23, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@italoacasas I’d still prefer to go with the version it was added in; adding some sort of changelog for individual methods is definitely planned.

italoacasas Jun 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok

addaleax commented Jun 23, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

LGTM with .end() nit addressed.

addaleax commented Jun 29, 2016

Copy link
Copy Markdown
Member

@italoacasas ping

italoacasas commented Jul 4, 2016

Copy link
Copy Markdown
Author

sorry for the late response. I was on vacation, I'll finish this PR this week.

italoacasas commented Jul 12, 2016

Copy link
Copy Markdown
Author

I'm back working on this.

italoacasas commented Jul 12, 2016

Copy link
Copy Markdown
Author

This should be ready, I don't find any other place where to add added

addaleax commented Jul 12, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax commented Jul 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 06cfecd0325e301be866c7ff9c7544f1a1cdcbec c897d0b, thanks!

addaleax closed this Jul 17, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 17, 2016
doc: add added: information for stream
c897d0b 
Ref: nodejs#6578
PR-URL: nodejs#7287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
doc: add added: information for stream
f7d3af6 
Ref: #6578
PR-URL: #7287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
evanlucas mentioned this pull request Jul 19, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
doc: add added: information for stream
9847f84 
Ref: #6578
PR-URL: #7287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

this is not landing cleanly on v4.x. Please submit a backport if you would like to see it land

italoacasas commented Sep 30, 2016

Copy link
Copy Markdown
Author

I'm going to do it tonight

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL