v6.3.1 Release Proposal by evanlucas · Pull Request #7782 · nodejs/node · GitHub

2016-07-21, Version 6.3.1 (Current), @evanlucas

Notable changes

buffer:
- Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
- Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
deps:
- Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
- Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638
repl: Fix issue with function redeclaration. (Prince J Wesley) #7794
util: Fix inspecting of boxed symbols. (Anna Henningsen) #7641

Commits

[3747d910ec] - benchmark: remove unused variables (Rich Trott) #7600
[41582722c8] - buffer: optimize hex_decode (Christopher Jeffrey) #7602
[4a3300e66b] - buffer: fix creating from zero-length ArrayBuffer (Ingvar Stepanyan) #7176
[71f84b5e6c] - build: add conflict marker check during CI lint (Brian White) #7625
[4480b14fda] - build: use BUILDTYPE when building V8 in Makefile (Michaël Zasso) #7482
[94a486a388] - build: add v8 requirement to test-v8* in Makefile (Michaël Zasso) #7482
[e5627278f1] - build: add --enable-d8 configure option (Ben Noordhuis) #7538
[933ff62fa5] - build: respect --shared-* flags for inspector deps (Сковорода Никита Андреевич) #7569
[9bb1024dc3] - child_process: Check stderr before accessing it (Robert Chiras) #6877
[f574bd4cec] - cluster: remove bind() and self (cjihrig) #7710
[164981af5f] - deps: bump V8 patchlevel for instanceof cherry-picks (Franziska Hinkelmann) #7638
[287006149b] - deps: cherry-pick 5b5d24b for X87 from V8 upstream (Franziska Hinkelmann) #7638
[e5cce7acfe] - deps: cherry-pick 3a903c4 for PPC from V8 upstream (Franziska Hinkelmann) #7638
[e23904523f] - deps: cherry-pick 2aa070be from V8 upstream (Franziska Hinkelmann) #7638
[d3f0a6a52f] - deps: cherry-pick 1f53e42 from v8 upstream (Ben Noordhuis) #7612
[cf8a4889db] - deps: v8_inspector no longer depends on wtf (Ali Ijaz Sheikh) #7751
[939cf6ddb2] - deps: no /safeseh for ml64.exe (Fedor Indutny) #7759
[abf86adee1] - deps: back-port d721121 from v8 upstream (Ben Noordhuis) #7633
[dbdcded866] - deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) #7531
[4839ef37a9] - doc: correcting misspelling (Vitaly Tomilov) #7797
[3343d46f2c] - doc: general improvments to events documentation (Sakthipriyan Vairamani) #7480
[e8a6a223ec] - doc: update readme with andrasq as a collaborator (Andras) #7801
[59ed303612] - doc: update CTC governance information (Rich Trott) #7719
[4b320adb49] - doc: correct sample output of buf.compare (Hargobind S. Khalsa) #7777
[9847f8459c] - doc: add added: information for stream (Italo A. Casas) #7287
[1f003590d6] - doc: fix inconsistencies in code style (saadq) #7745
[9c274e32fd] - doc: Warn against uncaughtException dependency. (Lance Ball) #6378
[fc4df0df6c] - doc: fix typo in stream doc (Kevin Donahue) #7738
[2a023bfd00] - doc: removed old git conflict markers from fs.md (Jaime Hidalgo García) #7590
[1d07d29bfe] - doc: fix typo in the CHANGELOG_V6 (vsemozhetbyt) #7568
[f15d2d6dae] - doc: fix util.deprecate() example (Evan Lucas) #7674
[58b70d34ee] - doc: link and highlight Object.assign (Sakthipriyan Vairamani) #7670
[cc7fdf429e] - doc: grammar fixes to event loop guide (Ryan Lewis) #7479
[a81ff702cc] - doc: dns.resolve fix callback argument description (Quentin Headen) #7532
[f0c335c347] - doc: add benchmark who-to-CC info (Rich Trott) #7604
[9e0cba0552] - doc: added information on how to run the linter. (Diosney Sarmiento) #7534
[e13ee29cbd] - doc: delete non-existing zlib constants (Franziska Hinkelmann) #7520
[663b103bc5] - doc: fix minor style issues in http.md (Rich Trott) #7528
[6c4d4596cc] - doc: updating REPLACEME tag during release (Gibson Fahnestock) #7514
[b4547340ee] - doc: fix detached child stdio example (cjihrig) #7540
[0f7b4efaaf] - doc: add bartosz sosnowski to colaborators (Bartosz Sosnowski) #7567
[77afeb2ec7] - doc,dgram: fix addMembership documentation (Santiago Gimeno) #7244
[11d6f1af59] - fs: rename event to eventType in fs.watch listener (Claudio Rodriguez) #7506
[989a2a1c92] - inspector: Unify event queues (Eugene Ostroukhov) #7271
[fc0ed2e8c7] - lib,benchmark,test: implement consistent braces (Rich Trott) #7630
[80ca0630a6] - net: export isIPv4, isIPv6 directly from cares (Sakthipriyan Vairamani) #7481
[72fc4ebca2] - repl: Mitigate vm Function redefinition in vm.runInContext #548 function redefinition issue (Prince J Wesley) #7794
[f97aa4be39] - src: remove unnecessary HandleScopes (Ben Noordhuis) #7711
[78dcf0d641] - src: fix handle leak in UDPWrap::Instantiate() (Ben Noordhuis) #7711
[dc766e6a6f] - src: fix handle leak in BuildStatsObject() (Ben Noordhuis) #7711
[96882e14d1] - src: fix handle leak in Buffer::New() (Ben Noordhuis) #7711
[fbc9ef84b8] - src: disable stdio buffering (Ben Noordhuis) #7610
[44c9a72aad] - test: add regression test for instanceof (Franziska Hinkelmann) #7638
[2e05e65916] - test: add known issue test for Array and Object have different values in REPL and in files #7788 (cjihrig) #7793
[7fb4794e19] - test: increase RAM requirement for intensive tests (Rich Trott) #7772
[61542e82c1] - test: ensure callback runs in test-vm-sigint (Rich Trott) #7768
[9e9d499b8b] - test: use mustCall() for simple flow tracking (cjihrig) #7753
[83cbf3175c] - test: avoid usage of mixed IPV6 addresses (Gireesh Punathil) #7702
[39f5d9ca7a] - test: fix flaky test-http-server-consumed-timeout (Rich Trott) #7717
[3ed0204f23] - test: s/assert.fail/common.fail as appropriate (cjihrig) #7735
[f7651d24d4] - test: improve error message in test-tick-processor (Rich Trott) #7693
[acb976ac26] - test: cleanup IIFE tests (cjihrig) #7694
[432cb353e1] - test: add common.rootDir (cjihrig) #7685
[9797969ad4] - test: fix old tty tests (Jeremiah Senkpiel) #7613
[37dc7954d8] - test: move parallel/test-tty-* to pseudo-tty/ (Jeremiah Senkpiel) #7613
[5192bed68c] - test: remove unused var from child-process-fork (Rich Trott) #7599
[e1aedbf671] - test: remove unused vars from http/https tests (Rich Trott) #7598
[64e2eed662] - test: remove unused var in test-tls-server-verify (Rich Trott) #7595
[8e50413b7e] - test: fix flaky test-fs-read-buffer-tostring-fail (Rich Trott) #7575
[447a8f26e1] - test: remove unused var in net-server-try-ports (Rich Trott) #7597
[326006527d] - test: remove unused var from stream2 test (Rich Trott) #7596
[97167291e7] - test: fix flaky test-net-write-slow (Rich Trott) #7555
[657fd7aee9] - test: skip doctool tests when js-yaml is missing (Anna Henningsen) #7218
[1576730ef3] - test,doc: clarify buf.indexOf(num) input range (Anna Henningsen) #7611
[49a6ea1b73] - timers: fix processing of nested timers (Jeremy Whitlock) #3063
[5a2ce3633f] - tools: consistent .eslintrc formatting (silverwind) #7691
[2a84da5d09] - tools: increase lint coverage (Rich Trott) #7647
[a82573d480] - tools: enforce JS brace style with linting (Rich Trott) #7630
[8efca46e78] - tools: fix broken format string (Sakthipriyan Vairamani) #7620
[2bef583f8a] - tools: cleanup no-build and build-only options (Sakthipriyan Vairamani) #7620
[df697c486e] - tools: update ESLint, fix unused vars bug (Rich Trott) #7601
[1a360d63db] - tools: remove unused variable (Rich Trott) #7594
[fa99dadda4] - tools: remove unnecessary imports and assignments (Sakthipriyan Vairamani) #7483
[0858e620e9] - util: inspect boxed symbols like other primitives (Anna Henningsen) #7641

Notable changes: * deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531) PR-URL: #7782

PR-URL: #7782

@evanlucas It might be worth waiting until the changes discussed in #7123 (comment) land. Looks like #7751 + another PR this week.

@gibfahn yea, this isn't going out today. I will incrementally updating this PR. If on Wednesday, v6.x is in a good state, we will push it out. If it needs to wait on things still, then we will wait :]. Thanks for the heads up though!

btw, there are a couple of open PRs labelled v6.x, I think they all are good to go and can be landed/included here?

@addaleax thanks! I'll take a look

@evanlucas Nice, thanks for picking it up this week. :D

Maybe mention the translations for the Windows installers in the Notable Changes?

@addaleax if they land they will be included, usually we don't hold releases on specific PRs?

@Fishrock123 Sorry, didn’t mean to imply these would need to be included or anything.

Notable changes: * deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531) * win,msi * add zh-CN translations for the installer (Minqi Pan) [#2569](#2569) * Added Italian translation (Matteo Collina) [#4647](#4647) PR-URL: #7782

PR-URL: #7782

did another round of commits. I will plan on shipping early tomorrow morning unless there are any objections.

CI: https://ci.nodejs.org/job/node-test-pull-request/3333/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/339/

@evanlucas Re: "deps: upgrade to V8 5.0.71.54", some of the back-ports bump the patch level. Might be confusing to release notes readers.

@bnoordhuis ah thanks for the heads up. Any suggestions on how to word to prevent confusion?

Have we resolved the licensing issue with node inspector. I don't think we should ship again without having done that.

looking at the issue where the things to be done are listed: #7123 (comment) it does not look like the licensing issues have been addressed. @ofrobots are those likely to get in soon ?

@mhdawson #7751 has landed already and we are waiting for one CL to land upstream for the rest. Hopefully we can get this finished today. /cc @eugeneo

Any suggestions on how to word to prevent confusion?

Feel free to leave my name out and just say "Upgrade to V8 5.0.71.xx."

@evanlucas the Italian translation introduced a bug that prevents the MSI to be generated. So, even if CI and CITGM are green, the release job will fail. You can either leave it out for this release or wait for #7798 to land (not sure if it qualifies as urgent and can land before 48h have passed?).

@joaocgreis thanks for the heads up. I would be fine with it landing sooner than the 48h if @nodejs/platform-windows is cool with it

I'm going to hold off on this until we know that the plinux issues are not from something in this branch

@evanlucas I thought the plinux hardware was just generally having issues? @mhdawson?

@jbergstroem / @rvagg ?

@Fishrock123 yea, I just wanted to confirm

Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782

PR-URL: #7782

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/3368/

@Fishrock123 there was a specific failure with one of the PRs as opposed to a general issue. Right now not aware of any general issues on the PPC machines. I did investigate and since it seemed tied to the specific PR/machine and as we see has not recreated in the Ci run above suggested we proceed.

@mhdawson I'm pretty sure that issue was happening on more than just that PR, but doesn't look to be happening anymore. Thanks for digging into that!!!

Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782

PR-URL: #7782

Ok, final CI before building binaries: https://ci.nodejs.org/job/node-test-pull-request/3376/

Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782

@evanlucas When I suggested "Upgrade to V8 5.0.71.xx", the idea was to replace the .xx with the real patch level at the time of release. :-)

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 18, 2016

evanlucas added arm Issues and PRs related to the ARM architecture. v6.x and removed arm Issues and PRs related to the ARM architecture. labels Jul 18, 2016

evanlucas force-pushed the v6.3.1-proposal branch from 1761692 to 0b45b85 Compare July 18, 2016 12:37

evanlucas added a commit that referenced this pull request Jul 18, 2016

2016-07-18, Version 6.3.1 (Current)

f909862

Notable changes: * deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531) PR-URL: #7782

evanlucas added a commit that referenced this pull request Jul 18, 2016

Working on v6.3.2

0b45b85

PR-URL: #7782

evanlucas force-pushed the v6.3.1-proposal branch from 0b45b85 to 75c4ff2 Compare July 19, 2016 10:57

evanlucas force-pushed the v6.3.1-proposal branch from 75c4ff2 to 3550192 Compare July 19, 2016 10:58

evanlucas added a commit that referenced this pull request Jul 19, 2016

Working on v6.3.2

3550192

PR-URL: #7782

evanlucas changed the title 2016-07-18, Version 6.3.1 (Current) v6.3.1 Release Proposal Jul 19, 2016

evanlucas force-pushed the v6.x branch from f3182f6 to cf8a488 Compare July 20, 2016 11:37

evanlucas force-pushed the v6.3.1-proposal branch from 3550192 to 0406ed8 Compare July 21, 2016 13:29

evanlucas added a commit that referenced this pull request Jul 21, 2016

Working on v6.3.2

0406ed8

PR-URL: #7782

evanlucas added 2 commits July 21, 2016 15:10

Working on v6.3.2

342a85b

PR-URL: #7782

evanlucas force-pushed the v6.3.1-proposal branch from 0406ed8 to 342a85b Compare July 21, 2016 20:10

evanlucas merged commit 342a85b into v6.x Jul 21, 2016

evanlucas deleted the v6.3.1-proposal branch July 21, 2016 22:29

cjihrig mentioned this pull request Aug 11, 2016

v6.4.0 Proposal #8070

Merged

v6.3.1 Release Proposal by evanlucas · Pull Request #7782 · nodejs/node · GitHub

Uh oh!

Uh oh!

v6.3.1 Release Proposal - #7782

v6.3.1 Release Proposal#7782evanlucas merged 2 commits intov6.xnodejs/node:v6.xfrom v6.3.1-proposalnodejs/node:v6.3.1-proposalCopy head branch name to clipboard

Conversation

evanlucas commented Jul 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2016-07-21, Version 6.3.1 (Current), @evanlucas

Notable changes

Commits

Uh oh!

gibfahn commented Jul 18, 2016

Uh oh!

evanlucas commented Jul 18, 2016

Uh oh!

addaleax commented Jul 18, 2016

Uh oh!

evanlucas commented Jul 18, 2016

Uh oh!

Fishrock123 commented Jul 18, 2016

Uh oh!

addaleax commented Jul 18, 2016

Uh oh!

evanlucas commented Jul 19, 2016

Uh oh!

evanlucas commented Jul 19, 2016

Uh oh!

bnoordhuis commented Jul 19, 2016

Uh oh!

evanlucas commented Jul 19, 2016

Uh oh!

mhdawson commented Jul 19, 2016

Uh oh!

mhdawson commented Jul 19, 2016

Uh oh!

ofrobots commented Jul 19, 2016

Uh oh!

bnoordhuis commented Jul 19, 2016

Uh oh!

joaocgreis commented Jul 19, 2016

Uh oh!

evanlucas commented Jul 19, 2016

Uh oh!

evanlucas commented Jul 21, 2016

Uh oh!

Fishrock123 commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evanlucas commented Jul 21, 2016

Uh oh!

evanlucas commented Jul 21, 2016

Uh oh!

mhdawson commented Jul 21, 2016

Uh oh!

evanlucas commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evanlucas commented Jul 21, 2016

Uh oh!

bnoordhuis commented Jul 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

v6.3.1 Release Proposal#7782
evanlucas merged 2 commits into
v6.xfrom
v6.3.1-proposal

evanlucas commented Jul 18, 2016 •
edited
Loading

Fishrock123 commented Jul 21, 2016 •
edited
Loading

evanlucas commented Jul 21, 2016 •
edited
Loading