FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: cherry-pick 1f53e42 from v8 upstream by bnoordhuis · Pull Request #7612 · nodejs/node · GitHub

/ node Public

deps: cherry-pick 1f53e42 from v8 upstream - #7612

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix7536
Jul 18, 2016
ConversationCommits (1)ChecksFiles changed
Merged

deps: cherry-pick 1f53e42 from v8 upstream#7612
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix7536

Conversation

bnoordhuis commented Jul 8, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Original commit message:

Handle symbols in FrameMirror#invocationText().

Fix a TypeError when putting together the invocationText for a
symbol method's stack frame.

See #7536.

Review-Url: https://codereview.chromium.org/2122793003
Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536

R=@nodejs/v8

Word from upstream is that 5.1 is abandoned so I haven't requested a back-port. (Well, I did, but it's unlikely to happen. I did request back-ports to 5.2 and 5.3.)

CI: https://ci.nodejs.org/job/node-test-pull-request/3218/
CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/183/

bnoordhuis added debugger v8 engine Issues and PRs related to the V8 dependency. labels Jul 8, 2016

targos commented Jul 8, 2016

Copy link
Copy Markdown
Member

LGTM

bnoordhuis commented Jul 8, 2016

Copy link
Copy Markdown
Member Author

java.io.IOException on pi3-raspbian-jessie but otherwise green. V8 test suite is green.

cjihrig commented Jul 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

deps: cherry-pick 1f53e42 from v8 upstream
f427d27 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See nodejs#7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{nodejs#37597}

Fixes: nodejs#7536
bnoordhuis closed this Jul 18, 2016
bnoordhuis deleted the fix7536 branch July 18, 2016 09:00
bnoordhuis merged commit f427d27 into nodejs:master Jul 18, 2016

bnoordhuis commented Jul 18, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Apologies, something went wrong while pushing to master. Landed in 5cdbbdf, thanks for the reviews.

bnoordhuis added a commit that referenced this pull request Jul 18, 2016
deps: cherry-pick 1f53e42 from v8 upstream
5cdbbdf 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See #7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536
PR-URL: #7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

evanlucas commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis Does this need to land in v6.x? If so, mind sending a backport PR? Thanks!

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Jul 19, 2016
deps: cherry-pick 1f53e42 from v8 upstream
bb187bb 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See nodejs#7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{nodejs#37597}

Fixes: nodejs#7536
PR-URL: nodejs#7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

bnoordhuis commented Jul 19, 2016

Copy link
Copy Markdown
Member Author

#7789 - v6.x

evanlucas pushed a commit that referenced this pull request Jul 21, 2016
deps: cherry-pick 1f53e42 from v8 upstream
d3f0a6a 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See #7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536
PR-URL: #7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
evanlucas mentioned this pull request Jul 21, 2016
Merged
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Jul 22, 2016
deps: cherry-pick 1f53e42 from v8 upstream
6c0bad0 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See nodejs/node#7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: nodejs/node#7536
PR-URL: nodejs/node#7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
ofrobots pushed a commit to ofrobots/node that referenced this pull request Aug 25, 2016
deps: cherry-pick 1f53e42 from v8 upstream
0ac21bc 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See nodejs#7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{nodejs#37597}

Fixes: nodejs#7536
PR-URL: nodejs#7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
evanlucas mentioned this pull request Aug 26, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
deps: cherry-pick 1f53e42 from v8 upstream
89677f7 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See #7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536
PR-URL: #7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
deps: cherry-pick 1f53e42 from v8 upstream
cfac04e 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See #7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536
PR-URL: #7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
deps: cherry-pick 1f53e42 from v8 upstream
4f29efc 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See #7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536
PR-URL: #7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
deps: cherry-pick 1f53e42 from v8 upstream
4369055 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See #7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: #7536
PR-URL: #7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Nov 9, 2016
deps: cherry-pick 1f53e42 from v8 upstream
80b2fc2 
Original commit message:

    Handle symbols in FrameMirror#invocationText().

    Fix a TypeError when putting together the invocationText for a
    symbol method's stack frame.

    See nodejs/node#7536.

    Review-Url: https://codereview.chromium.org/2122793003
    Cr-Commit-Position: refs/heads/master@{#37597}

Fixes: nodejs/node#7536
PR-URL: nodejs/node#7612
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
ofrobots added a commit to ofrobots/node that referenced this pull request Jan 11, 2017
deps: V8: fix debug backtrace for symbols
d57f561 
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: nodejs#7612
Ref: nodejs#9298
ofrobots mentioned this pull request Jan 11, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Jan 12, 2017
deps: V8: fix debug backtrace for symbols
2677b9b 
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: #7612
Ref: #9298

PR-URL: #10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
deps: V8: fix debug backtrace for symbols
78ab697 
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: #7612
Ref: #9298

PR-URL: #10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
deps: V8: fix debug backtrace for symbols
81e9a3b 
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: #7612
Ref: #9298

PR-URL: #10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Feb 22, 2017
deps: V8: fix debug backtrace for symbols
2a954bf 
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: nodejs/node#7612
Ref: nodejs/node#9298

PR-URL: nodejs/node#10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL