V4.6.2 proposal - #9298
Closed
MylesBorins wants to merge 221 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add an option to the configure script for building d8. Useful for testing V8 standalone. PR-URL: #7538 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Manual backport from master to 4.x stream, original commit message follows. I often want to run a test many times to see if a failure can be recreated and I believe this is a common use case. We even have this job in the CI https://ci.nodejs.org/job/node-stress-single-test/configure but often you want to run it on a specific machine. This patch adds the --repeat option so that you can repeat the selected set of tests a number of times. Given existing options in test.py this will allow you to run one or more tests for the number of repeats specified. For example: tools/test.py -j8 --repeat 1000 parallel/test-process-exec-argv runs the test-process-exec-argv test 1000 times, running 8 copies in parallel tools/test.py --repeat 2 would run the entire test suite twice. PR-URL: #6700 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: #8025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7479 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The function objects encapsulating `isIPv4` and `isIPv6` are not necessary. They can be directly exposed from `cares`. PR-URL: #7481 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Inspect boxed symbol objects in the same way other boxed primitives are inspected. Fixes: #7639 PR-URL: #7641 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Use `msvs_settings.MASM.UseSafeExceptionHandlers` when building OpenSSL assembly code on Windows. This option appends `/safeseh` to the list of assembler flags when building `.asm` files on Windows. Having this option in place, separate rules in `masm_compile.gypi` are no longer needed. Fix: #7426 PR-URL: #7427 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bert Belder <bertbelder@gmail.com>
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it if `target_arch=="x64"`. See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx PR-URL: #7759 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Since I was doing the necessary git archaeology anyway, I took the time to add YAML information to the docs about when `addMembership()` and `dropMembership()` first appeared in their current forms. PR-URL: #6753 Ref: #6578 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This change is in preparation for lint-enforced brace style. PR-URL: #8348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This change is in preparation for lint enforcement of brace style. PR-URL: #8348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Enable `brace-style` in ESLint. Ref: #7094 (comment) PR-URL: #8348 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Set the `req.buffer` property, which serves as a way of keeping a `Buffer` alive that is being written to a stream, on the C++ side instead of the JS side. This closes a hole where buffers that were temporarily created in order to write strings with uncommon encodings (e.g. `hex`) were passed to the native side without being set as `req.buffer`. Fixes: #8251 PR-URL: #8252 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
We will be introducing many more critical sections in the upcoming multi-isolate changes, so let's make manual synchronization a thing of the past. PR-URL: #7334 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Extend linting to tools/license2rtf.js and any other JS that gets added to the `tools` directory by default. This incidentally simplifies lint invocation. Ref: #8349 PR-URL: #7647 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: #8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Some constants in the zlib docs are not in the actual code: zlib.Z_BINARY zlib.Z_TEXT zlib.Z_ASCII zlib.Z_UNKNOWN Also handled in #7203, but marked as semver-major, so will not land in v6.x. Fixes: #7204 PR-URL: #7520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
The arguments object is not created for arrow functions so the example was incorrect. PR-URL: #7674 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Update some outdated material. Provide some minor fixes. Wrap to 80 characters. PR-URL: #7719 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> PR-URL: #7801
There has been some question about whether the #node.js irc channel falls under the TSC oversight or not. See: #7746 This clarifies that the #node.js irc channel is a community provided resource that is not currently directly under the oversight of the TSC/CTC. PR-URL: #7810 Reviewed-By: Bryan Hughes <bryan@nebri.us> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #7877 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
CTC quorum rules were not in writing. There was an informal understanding between CTC members. Document the rules to avoid differences in interpretation. PR-URL: #7813 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Provide example activities to better distinguish Collaborator activities from CTC member activities. PR-URL: #7744 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Julien Gilli <jgilli@nodejs.org>
PR-URL: #7900 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Add language identifying a request for voluntary resignation as the typical mechanism for addressing inactive CTC members. PR-URL: #7720 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
force-pushed
the
v4.6.2-proposal
branch
from
923b3ac to
0bcb2f2
Compare
October 26, 2016 18:40
MylesBorins
added a commit
that referenced
this pull request
Oct 26, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.
Notable Changes
* build:
- It is now possible to build the documentation from the release
tarball (Anna Henningsen)
#8413
* buffer:
- Buffer will no longer incorrectly return a zero filled buffer when
an encoding is passed (Teddy Katz)
#9238
* deps:
- upgrade npm in LTS to 2.15.11 (Kat Marchán)
#8928
* repl:
- Enable tab completion for global properties (Lance Ball)
#7369
* url:
- `url.format()` will now encode all `#` in `search` (Ilkka Myller)
#8072
PR-URL: #9298
Copy link
Copy Markdown
Contributor
Author
|
ci: https://ci.nodejs.org/job/node-test-pull-request/4690/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
With this being a semver patch release I would like to do 2 weeks of RC followed by a release on november 8. If anyone has concerns about this please let me know. /cc @nodejs/ctc @nodejs/lts |
Sorry, something went wrong.
Comment thread
CHANGELOG.md
Outdated
| ## Notable Changes | ||
|
|
||
| * **build**: It is now possible to build the documentation from the release tarball (Anna Henningsen) [#8413](https://github.com/nodejs/node/pull/8413) | ||
| * **buffer**: Buffer will no longer incorrectly return a zero filled buffer when an encoding is passed (Teddy Katz) [#9238](https://github.com/nodejs/node/pull/9238) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Is this supposed to say Buffer.alloc instead of just Buffer?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
fixed
Sorry, something went wrong.
MylesBorins
force-pushed
the
v4.6.2-proposal
branch
from
0bcb2f2 to
7c009cc
Compare
October 26, 2016 18:55
MylesBorins
added a commit
that referenced
this pull request
Oct 26, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.
Notable Changes
* build:
- It is now possible to build the documentation from the release
tarball (Anna Henningsen)
#8413
* buffer:
- Buffer.alloc() will no longer incorrectly return a zero filled
buffer when an encoding is passed (Teddy Katz)
#9238
* deps:
- upgrade npm in LTS to 2.15.11 (Kat Marchán)
#8928
* repl:
- Enable tab completion for global properties (Lance Ball)
#7369
* url:
- `url.format()` will now encode all `#` in `search` (Ilkka Myller)
#8072
PR-URL: #9298
Copy link
Copy Markdown
Contributor
Author
|
one more citgm for posterity: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/432/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM! |
Sorry, something went wrong.
Git has been using my Long format fingerprint in the tagging messages, this has been causing the release script to fail on my keys. It would also be wise to be using the long format on keys based on some attacks that hack been found in the wild around short keys. PR-URL: #9258 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.
Notable Changes
* build:
- It is now possible to build the documentation from the release
tarball (Anna Henningsen)
#8413
* buffer:
- Buffer.alloc() will no longer incorrectly return a zero filled
buffer when an encoding is passed (Teddy Katz)
#9238
* deps:
- upgrade npm in LTS to 2.15.11 (Kat Marchán)
#8928
* repl:
- Enable tab completion for global properties (Lance Ball)
#7369
* url:
- `url.format()` will now encode all `#` in `search` (Ilkka Myller)
#8072
PR-URL: #9298
MylesBorins
force-pushed
the
v4.6.2-proposal
branch
from
7c009cc to
4db97b8
Compare
November 7, 2016 15:41
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/collaborators @nodejs/lts @nodejs/ctc This release is planned to go out tomorrow. Please give one more look at the changelog and make sure that nothing seems out of place |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Failures of citgm included:
|
Sorry, something went wrong.
MylesBorins
added a commit
that referenced
this pull request
Nov 8, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.
Notable Changes
* build:
- It is now possible to build the documentation from the release
tarball (Anna Henningsen)
#8413
* buffer:
- Buffer.alloc() will no longer incorrectly return a zero filled
buffer when an encoding is passed (Teddy Katz)
#9238
* deps:
- upgrade npm in LTS to 2.15.11 (Kat Marchán)
#8928
* repl:
- Enable tab completion for global properties (Lance Ball)
#7369
* url:
- `url.format()` will now encode all `#` in `search` (Ilkka Myller)
#8072
PR-URL: #9298
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Nov 11, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.
Notable Changes
* build:
- It is now possible to build the documentation from the release
tarball (Anna Henningsen)
nodejs/node#8413
* buffer:
- Buffer.alloc() will no longer incorrectly return a zero filled
buffer when an encoding is passed (Teddy Katz)
nodejs/node#9238
* deps:
- upgrade npm in LTS to 2.15.11 (Kat Marchan)
nodejs/node#8928
* repl:
- Enable tab completion for global properties (Lance Ball)
nodejs/node#7369
* url:
- `url.format()` will now encode all `#` in `search` (Ilkka Myller)
nodejs/node#8072
PR-URL: nodejs/node#9298
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
ofrobots
added a commit
to ofrobots/node
that referenced
this pull request
Jan 11, 2017
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: nodejs#7612 Ref: nodejs#9298
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2017
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: #7612 Ref: #9298 PR-URL: #10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: #7612 Ref: #9298 PR-URL: #10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: #7612 Ref: #9298 PR-URL: #10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Feb 22, 2017
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite correct as it depends on a runtime function %SymbolDescriptiveString that doesn't exist on v4.x. We can use %SymbolDescription instead. Ref: nodejs/node#7612 Ref: nodejs/node#9298 PR-URL: nodejs/node#10732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2016-11-08, Version 4.6.2 'Argon' (LTS), @thealphanerd
This LTS release comes with 219 commits. This includes 80 commits that are docs related, 58 commits that are test related, 20 commits that are build / tool related, and 9 commits that are updates to dependencies.
Notable Changes
Commits