test,doc: clarify buf.indexOf(num) input range - #7611
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Hopefully clarify the behaviour of `buffer.indexOf()` and `buffer.includes()` for numbers in that they will be truncated to uint8s. Add tests for that behaviour. Fixes: nodejs#7591
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM if CI is green. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Landed in a7105a8, CI was green with 2 unrelated FreeBSD failures. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@addaleax should this be backportd? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
yeah, I guess I’ll put a backport together, this definitely won’t land cleanly… |
Sorry, something went wrong.
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Sep 9, 2016
Hopefully clarify the behaviour of `buffer.indexOf()` and `buffer.includes()` for numbers in that they will be truncated to uint8s. Add tests for that behaviour. Fixes: nodejs#7591 PR-URL: nodejs#7611 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
buffer
Description of change
Hopefully clarify the behaviour of buffer.indexOf() and buffer.includes() for numbers in that they will be truncated to uint8s.
Add tests for that behaviour.
Fixes: #7591
CI: https://ci.nodejs.org/job/node-test-commit/4022/