FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: correct sample output of buf.compare by khalsah · Pull Request #7777 · nodejs/node · GitHub

/ node Public

doc: correct sample output of buf.compare - #7777

Closed
khalsah wants to merge 1 commit into
nodejs:masterfrom
khalsah:doc-fix-buf-compare
Closed

doc: correct sample output of buf.compare#7777
khalsah wants to merge 1 commit into
nodejs:masterfrom
khalsah:doc-fix-buf-compare

Conversation

khalsah commented Jul 17, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

comparing the buffers ABC and ABCD returns -1 not 1.

comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.
nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jul 17, 2016

Copy link
Copy Markdown
Member

LGTM

cjihrig commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

LGTM. Good catch.

cjihrig commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

Landed in 59741a9. Thanks!

cjihrig closed this Jul 18, 2016
cjihrig pushed a commit that referenced this pull request Jul 18, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.

PR-URL: #7777
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.

PR-URL: #7777
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.

PR-URL: #7777
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.

PR-URL: #7777
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.

PR-URL: #7777
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Comparing the buffers `ABC` and `ABCD` returns `-1` not `1`.

PR-URL: #7777
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Oct 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL