FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: accept expected AIX result test-stdio-closed by Trott · Pull Request #8755 · nodejs/node · GitHub

/ node Public

test: accept expected AIX result test-stdio-closed - #8755

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:stdio-aix
ConversationCommits (1)ChecksFiles changed
Closed

test: accept expected AIX result test-stdio-closed#8755
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:stdio-aix

Conversation

Trott commented Sep 23, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375

/cc @mhdawson @gireeshpunathil @bnoordhuis

Trott added the test Issues and PRs related to the tests. label Sep 23, 2016
nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 23, 2016
jasnell approved these changes Sep 23, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mscdex added the process Issues and PRs related to the process subsystem. label Sep 24, 2016
Trott force-pushed the stdio-aix branch 2 times, most recently from 9d392e5 to f959362 Compare September 24, 2016 01:55
test: accept expected AIX result test-stdio-closed
157381c 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: nodejs#8375

Trott commented Sep 24, 2016

Copy link
Copy Markdown
Member Author

Think I have it now. Let's try CI again: https://ci.nodejs.org/job/node-test-pull-request/4253/

Trott commented Sep 24, 2016

Copy link
Copy Markdown
Member Author

Oh, hi there, green AIX CI run. It's been a while.

gibfahn commented Sep 24, 2016

Copy link
Copy Markdown
Member

LGTM

imyller approved these changes Sep 24, 2016
View reviewed changes

imyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell pushed a commit that referenced this pull request Sep 26, 2016
test: accept expected AIX result test-stdio-closed
e65a2d7 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

jasnell commented Sep 26, 2016

Copy link
Copy Markdown
Member

Landed in e65a2d7. Thank you!

jasnell closed this Sep 26, 2016
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
test: accept expected AIX result test-stdio-closed
1420537 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
test: accept expected AIX result test-stdio-closed
b397c16 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
test: accept expected AIX result test-stdio-closed
2a95704 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: nodejs#8375
PR-URL: nodejs#8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
test: accept expected AIX result test-stdio-closed
5e4d898 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

 Conflicts:
	test/parallel/parallel.status
rvagg pushed a commit that referenced this pull request Oct 18, 2016
test: accept expected AIX result test-stdio-closed
47ada06 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
test: accept expected AIX result test-stdio-closed
b64828d 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
Trott deleted the stdio-aix branch January 13, 2022 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
imyller imyller approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AIX: parallel/test-stdio-closed

8 participants

Back | FazBrowse Home | New Git URL