FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update readme with andrasq as a collaborator by andrasq · Pull Request #7801 · nodejs/node · GitHub

/ node Public

doc: update readme with andrasq as a collaborator - #7801

Closed
andrasq wants to merge 1 commit into
nodejs:masterfrom
andrasq:andrasq-collaborator
Closed

doc: update readme with andrasq as a collaborator#7801
andrasq wants to merge 1 commit into
nodejs:masterfrom
andrasq:andrasq-collaborator

Conversation

andrasq commented Jul 19, 2016
edited by Trott
Loading

Copy link
Copy Markdown
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 19, 2016

Trott commented Jul 19, 2016

Copy link
Copy Markdown
Member

LGTM. We don't have a requirement that people include a surname or anything, right? Whatever they wish to be identified by is OK? Or am I mistaken about that?

andrasq commented Jul 19, 2016

Copy link
Copy Markdown
Author

Copy link
Copy Markdown
Contributor

LGTM. Welcome aboard!

andrasq commented Jul 20, 2016

Copy link
Copy Markdown
Author

landed in f1d804a

andrasq pushed a commit that referenced this pull request Jul 20, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
andrasq closed this Jul 20, 2016

Copy link
Copy Markdown
Member

We don't have a requirement that people include a surname or anything, right?

Not a requirement, just a preference.

evanlucas pushed a commit that referenced this pull request Jul 21, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
MylesBorins mentioned this pull request Oct 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL