FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

debug: use arrow functions for lexical `this` by originalfoo · Pull Request #7415 · nodejs/node · GitHub

/ node Public

debug: use arrow functions for lexical this - #7415

Closed
originalfoo wants to merge 3 commits into
nodejs:masterfrom
originalfoo:_debug_agent7414
ConversationCommits (3)ChecksFiles changed
Closed

debug: use arrow functions for lexical this#7415
originalfoo wants to merge 3 commits into
nodejs:masterfrom
originalfoo:_debug_agent7414

Conversation

originalfoo commented Jun 25, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

debug

( specifically: lib/_debug_agent.js )

Description of change

Use arrow functions to replace 3x var self = this; ... function() { self.whatever() } pattern.

See #7414 for more details.

mscdex commented Jun 25, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/3076/

cjihrig commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

2 similar comments

jasnell commented Jun 27, 2016

Copy link
Copy Markdown
Member

LGTM

mscdex commented Jun 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell commented Aug 18, 2016

Copy link
Copy Markdown
Member

New CI since it appears this fell through the cracks: https://ci.nodejs.org/job/node-test-pull-request/3742/

jasnell pushed a commit that referenced this pull request Aug 18, 2016
debugger: use arrow function for lexical this
a9387db 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell commented Aug 18, 2016

Copy link
Copy Markdown
Member

Landed in a9387db!

jasnell closed this Aug 18, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
debugger: use arrow function for lexical this
c406ad8 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
debugger: use arrow function for lexical this
9de701a 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
debugger: use arrow function for lexical this
0d4bb79 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
debugger: use arrow function for lexical this
74f76f6 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
debugger: use arrow function for lexical this
6dd3390 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
debugger: use arrow function for lexical this
2b93333 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL