FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for util by lpinca · Pull Request #8206 · nodejs/node · GitHub

/ node Public

doc: add added: information for util - #8206

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/added-util
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: information for util#8206
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/added-util

Conversation

lpinca commented Aug 21, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

nodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Aug 21, 2016
lpinca reviewed Aug 21, 2016
View reviewed changes
Comment thread doc/api/util.md Outdated

lpinca Aug 21, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is when the module has been renamed. It was called sys before, not sure if it's better to show when the method was added to sys.

Fishrock123 Aug 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is probably fine.

Qard Aug 22, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think of the added marks as a reference for the user to understand "how far back can I expect this thing to be in this place", so existence elsewhere before then is kind of irrelevant.

silverwind commented Aug 21, 2016

Copy link
Copy Markdown
Contributor

LGTM

3 similar comments

jasnell commented Aug 21, 2016

Copy link
Copy Markdown
Member

LGTM

Qard commented Aug 22, 2016

Copy link
Copy Markdown
Member

LGTM

bengl commented Aug 23, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Aug 23, 2016
doc: add added: information for util
16f4b8e 
PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>

jasnell commented Aug 23, 2016

Copy link
Copy Markdown
Member

Landed in 16f4b8e

jasnell closed this Aug 23, 2016
lpinca deleted the add/added-util branch August 23, 2016 18:37
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
doc: add added: information for util
d9142b4 
PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
evanlucas mentioned this pull request Aug 24, 2016
Merged
lpinca mentioned this pull request Aug 26, 2016
Closed
2 tasks
sam-github mentioned this pull request Sep 8, 2016
Closed
36 tasks

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

This doesn't land cleanly on v4.x please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
doc: add added: information for util
eaa49f2 
PR-URL: nodejs#8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
lpinca mentioned this pull request Oct 1, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
doc: add added: information for util
7ac5aef 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
doc: add added: information for util
383419f 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
doc: add added: information for util
b35dcbf 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
doc: add added: information for util
b92e3fc 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL