FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for crypto by lpinca · Pull Request #8281 · nodejs/node · GitHub

/ node Public

doc: add added: information for crypto - #8281

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/added-crypto
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: information for crypto#8281
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/added-crypto

Conversation

lpinca commented Aug 26, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 26, 2016
lpinca reviewed Aug 26, 2016
View reviewed changes
Comment thread doc/api/crypto.md Outdated

lpinca Aug 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This signature was added in v0.11.12. Maybe it makes sense to use this version instead of v0.5.0. See below for the original signature.

Edit: To be picky the second argument of the original version was the encoding so I'm not sure.

benjamingr Aug 26, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think 0.11.12 does make more sense. If someone wants to look at the 0.10 docs to find the original that's fine.

lpinca Aug 26, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I used v0.5.0 here as per this comment but in the same pr I used two different versions (v0.11.13 and v0.1.99) for dgram.createSocket.
I'm going to do the same here.

benjamingr commented Aug 26, 2016

Copy link
Copy Markdown
Member

LGTM + left comment

addaleax commented Sep 10, 2016

Copy link
Copy Markdown
Member

Rubber-stamp LGTM

jasnell commented Sep 12, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Sep 12, 2016
doc: add added: information for crypto
cfe8278 
PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Sep 12, 2016

Copy link
Copy Markdown
Member

Landed in cfe8278

jasnell closed this Sep 12, 2016
lpinca deleted the add/added-crypto branch September 12, 2016 06:05
sam-github mentioned this pull request Sep 12, 2016
Closed
36 tasks
Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
doc: add added: information for crypto
09da575 
PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
doc: add added: information for crypto
f68f26c 
PR-URL: nodejs#8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
lpinca mentioned this pull request Oct 1, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
doc: add added: information for crypto
0d8a512 
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
doc: add added: information for crypto
2fd78af 
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
doc: add added: information for crypto
d9c4584 
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
doc: add added: information for crypto
6effc4a 
Ref: #8885

PR-URL: #8281
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
tniessen added a commit to tniessen/node that referenced this pull request Feb 8, 2018
doc: add missing meta for createCipheriv
2118fd6 
Refs: nodejs#8281
tniessen mentioned this pull request Feb 8, 2018
Closed
2 tasks
tniessen added a commit that referenced this pull request Feb 9, 2018
doc: add missing meta for createCipheriv
95a35bc 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: add missing meta for createCipheriv
1d0be7c 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: add missing meta for createCipheriv
64aae93 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: add missing meta for createCipheriv
97b5c1f 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: add missing meta for createCipheriv
832e052 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
doc: add missing meta for createCipheriv
f8ad381 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
doc: add missing meta for createCipheriv
4a73e7b 
PR-URL: nodejs#18651
Refs: nodejs#8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL