FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for events by lpinca · Pull Request #7822 · nodejs/node · GitHub

/ node Public

doc: add added: information for events - #7822

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/added-events
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: information for events#7822
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/added-events

Conversation

lpinca commented Jul 21, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jul 21, 2016
mscdex reviewed Jul 21, 2016
View reviewed changes
Comment thread doc/api/events.md Outdated

mscdex Jul 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be v0.1.33.

lpinca Jul 21, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You are correct, I'll fix it.

mscdex Jul 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, it's actually v0.1.26.

lpinca force-pushed the add/added-events branch from 6cf7d2b to 7bbdd3b Compare July 21, 2016 16:44

mscdex commented Jul 21, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

EventEmitter.listenerCount is missing metadata. It was added in v0.9.12. Deprecated in v4.0.0.

EventEmitter.defaultMaxListeners is also missing metadata. It was added in v0.11.2.

lpinca force-pushed the add/added-events branch from 7bbdd3b to 6e3999d Compare July 21, 2016 16:49
mscdex reviewed Jul 21, 2016
View reviewed changes
Comment thread doc/api/events.md Outdated

mscdex Jul 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I forgot to add that there should also be: deprecated: v4.0.0

lpinca force-pushed the add/added-events branch from 6e3999d to cbc3836 Compare July 21, 2016 16:56

mscdex commented Jul 21, 2016

Copy link
Copy Markdown
Contributor

LGTM

lpinca commented Jul 21, 2016

Copy link
Copy Markdown
Member Author

I missed quite a few things, thanks for reviewing @mscdex.

jasnell commented Aug 5, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Aug 5, 2016
doc: add added: information for events
769f63c 
PR-URL: #7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

jasnell commented Aug 5, 2016

Copy link
Copy Markdown
Member

Landed in 769f63c

jasnell closed this Aug 5, 2016
lpinca deleted the add/added-events branch August 6, 2016 05:04
cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
doc: add added: information for events
b20518a 
PR-URL: #7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
cjihrig mentioned this pull request Aug 11, 2016
Merged
sam-github mentioned this pull request Aug 16, 2016
Closed
36 tasks

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

This is not backporting to v4.x cleanly. Please feel free to manually backport

lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
doc: add added: information for events
a739871 
PR-URL: nodejs#7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
lpinca mentioned this pull request Oct 1, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
doc: add added: information for events
abdb278 
Ref: #8879

PR-URL: #7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
doc: add added: information for events
328693b 
Ref: #8879

PR-URL: #7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
doc: add added: information for events
b872934 
Ref: #8879

PR-URL: #7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
doc: add added: information for events
578bf51 
Ref: #8879

PR-URL: #7822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL