FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Add @joshgav to collaborators. by joshgav · Pull Request #8146 · nodejs/node · GitHub

/ node Public

doc: Add @joshgav to collaborators. - #8146

Closed
joshgav wants to merge 1 commit into
nodejs:masterfrom
joshgav:add-joshgav
ConversationCommits (1)ChecksFiles changed
Closed

doc: Add @joshgav to collaborators.#8146
joshgav wants to merge 1 commit into
nodejs:masterfrom
joshgav:add-joshgav

Conversation

joshgav commented Aug 17, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add @joshgav to collaborators.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 17, 2016
addaleax reviewed Aug 17, 2016
View reviewed changes
Comment thread README.md Outdated

addaleax Aug 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You’re inserting yourself in the middle of julianduque’s entry… not sure that’s intended? ;)

joshgav Aug 17, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wow you're fast :) Already corrected.

Trott commented Aug 17, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

addaleax commented Aug 17, 2016

Copy link
Copy Markdown
Member

LGTM

joshgav added a commit that referenced this pull request Aug 17, 2016
doc: add @joshgav to collaborators
b417087 
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8146

cjihrig commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott commented Aug 17, 2016

Copy link
Copy Markdown
Member

@joshgav Looks like we overlooked the critical last step: Closing the PR with a "Landed in " comment... Sorry I didn't catch that at the time... Can you close this with the comment?

joshgav commented Aug 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

landed in b417087

joshgav closed this Aug 17, 2016
evanlucas pushed a commit that referenced this pull request Aug 20, 2016
doc: add @joshgav to collaborators
5d37b49 
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8146
joshgav deleted the add-joshgav branch August 23, 2016 15:09
evanlucas added a commit that referenced this pull request Aug 24, 2016
2016-08-24, Version 6.4.1 (Current)
99c9a6b 
Notable changes:

* **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154
* **inspector**:
  * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021
  * add support for uncaught exception (Aleksei Koziatinskii) #8043
* **meta**: add @joshgav to collaborators (Josh Gavant) #8146
* **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145
* ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143
evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
doc: add @joshgav to collaborators
24c3d25 
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8146
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
doc: add @joshgav to collaborators
3c561da 
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8146
rvagg pushed a commit that referenced this pull request Oct 18, 2016
doc: add @joshgav to collaborators
37d6a7a 
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8146
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
doc: add @joshgav to collaborators
2032bba 
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8146
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL