doc: encourage 2FA before onboarding by Trott · Pull Request #8776 · nodejs/node · GitHub

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

In the onboarding document, add a note to ask the new Collaborator if
they are using two-factor authentication on their GitHub account. If
they are not, suggest that they enable it as their account will have
elevated privileges in mamy of the Node.js repositories.

/cc @ChALkeR

LGTM

typo, here and in the commit message: mamy

Perhaps "strongly suggest". I'd even prefer "wait until they've enabled" but this is probably a discussion that lives someplace else.

@jbergstroem Let's keep it as «suggest» for now and re-evaluate later, there could be some issues with enabling 2FA that we are not aware of, and we don't want to scare new people from being added as collaborators.

Once we collect some feedback/results on this process, we could make it stricter, either by «strongly suggest» or by even enforcing 2FA as a hard requirement.

Isn't this a very lengthy line?

@thefourtheye It's wrapped now. Thanks.

@addaleax typo fixed, thanks!

LGTM with typo fixed

LGTM with a typo fix.

LGTM with fix and postponing the 2fa talk.

Btw, /cc @nodejs/collaborators.

LGTM. However I experienced major disruptions in my dev workflows when I activated this. Obviously there are privileges, but imo git is resilient enough and collaborators usually don't have to many org rights in the beginning, no?

@eljefedelrodeodeljefe I'm curious, what kind of disruptions have you encountered? There are many ways to do 2fa, you don't even have to have a (smart)phone.

@mscdex nothing too blocking, but annoyances like: needing to re-authenticate everywhere, this sometimes not working properly, re-auth in multiple terminals, git clients on the same machine, Not being able to quickly pull / clone on remote machines, where you don't store config, especially in non-OSS environments, sometimes auth on remote not even working, the list goes on.

@eljefedelrodeodeljefe Is that with https? I've never had any problems with ssh.

In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories.

LGTM

ugh sausage fingers... sorry

LGTM

In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: nodejs#8776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Landed in cad0423

In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: #8776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

I'm curious, what are the extra privileges?

In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: #8776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

@AndreasMadsen I believe pushing to master, for example

@thealphanerd I could do that before enabling 2FA.

I could do that before enabling 2FA.

We encourage 2FA. That is all (at this time). There is currently no connection between "enable 2FA" and "get more privileges" for the typical Collaborator.

2FA is required if you're on the security team, and possibly the build team as well.

Do we also have requirements for PGP signing for both of those groups as well? Is this written down anywhere?

Do we also have requirements for PGP signing for both of those groups as well? Is this written down anywhere?

Signing what exactly?

In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: #8776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott added the doc Issues and PRs related to the documentations. label Sep 25, 2016

addaleax approved these changes Sep 25, 2016

View reviewed changes

imyller approved these changes Sep 25, 2016

View reviewed changes

ChALkeR approved these changes Sep 25, 2016

View reviewed changes

jbergstroem approved these changes Sep 25, 2016

View reviewed changes

not-an-aardvark approved these changes Sep 25, 2016

View reviewed changes

eljefedelrodeodeljefe approved these changes Sep 25, 2016

View reviewed changes

Trott force-pushed the 2fa branch from 89a9ee5 to 81af073 Compare September 27, 2016 21:51

Trott force-pushed the 2fa branch from 81af073 to 1404717 Compare September 27, 2016 21:53

thefourtheye approved these changes Sep 28, 2016

View reviewed changes

MylesBorins closed this Sep 28, 2016

MylesBorins reopened this Sep 28, 2016

MylesBorins approved these changes Sep 28, 2016

View reviewed changes

jasnell approved these changes Sep 28, 2016

View reviewed changes

Trott closed this Sep 29, 2016

MylesBorins added the land-on-v4.x label Sep 30, 2016

MylesBorins mentioned this pull request Oct 26, 2016

V4.6.2 proposal #9298

Closed

Trott deleted the 2fa branch October 19, 2021 13:18

doc: encourage 2FA before onboarding by Trott · Pull Request #8776 · nodejs/node · GitHub

Uh oh!

Uh oh!

doc: encourage 2FA before onboarding - #8776

doc: encourage 2FA before onboarding#8776Trott wants to merge 1 commit intonodejs:masternodejs/node:masterfrom Trott:2faTrott/io.js:2faCopy head branch name to clipboard

Conversation

Trott commented Sep 25, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

Trott commented Sep 25, 2016

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax Sep 25, 2016

Choose a reason for hiding this comment

Uh oh!

jbergstroem Sep 25, 2016

Choose a reason for hiding this comment

Uh oh!

ChALkeR Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thefourtheye Sep 26, 2016

Choose a reason for hiding this comment

Uh oh!

Trott Sep 27, 2016

Choose a reason for hiding this comment

Uh oh!

Trott Sep 27, 2016

Choose a reason for hiding this comment

Uh oh!

imyller left a comment

Choose a reason for hiding this comment

Uh oh!

ChALkeR left a comment

Choose a reason for hiding this comment

Uh oh!

jbergstroem left a comment

Choose a reason for hiding this comment

Uh oh!

ChALkeR commented Sep 25, 2016

Uh oh!

eljefedelrodeodeljefe left a comment

Choose a reason for hiding this comment

Uh oh!

mscdex commented Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eljefedelrodeodeljefe commented Sep 25, 2016

Uh oh!

gibfahn commented Sep 26, 2016

Uh oh!

MylesBorins commented Sep 28, 2016

Uh oh!

MylesBorins commented Sep 28, 2016

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Sep 29, 2016

Uh oh!

AndreasMadsen commented Sep 29, 2016

Uh oh!

MylesBorins commented Sep 30, 2016

Uh oh!

AndreasMadsen commented Oct 1, 2016

Uh oh!

Trott commented Oct 1, 2016

Uh oh!

mikeal commented Oct 3, 2016

Uh oh!

addaleax commented Oct 4, 2016

Uh oh!

Reviewers

Assignees

Labels

doc: encourage 2FA before onboarding#8776
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:2fa

ChALkeR Sep 25, 2016 •
edited
Loading

mscdex commented Sep 25, 2016 •
edited
Loading