FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove platform assumption from CONTRIBUTING by BethGriggs · Pull Request #7783 · nodejs/node · GitHub

/ node Public

doc: remove platform assumption from CONTRIBUTING - #7783

Closed
BethGriggs wants to merge 1 commit into
nodejs:masterfrom
BethGriggs:issue-7646-contributing-branch
ConversationCommits (1)ChecksFiles changed
Closed

doc: remove platform assumption from CONTRIBUTING#7783
BethGriggs wants to merge 1 commit into
nodejs:masterfrom
BethGriggs:issue-7646-contributing-branch

Conversation

BethGriggs commented Jul 18, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change
  • Specify that the ‘make test’ commands are Unix/OS X specific.
  • Link to BUILDING.md for other platform commands.

Fixes: #7646

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 18, 2016

evanlucas commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

Should we maybe include the windows commands here as well?

Fishrock123 commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

Yes it would be useful to directly say the windows command here. You should be able to find it at https://github.com/nodejs/node/blob/master/BUILDING.md#windows

Fishrock123 commented Jul 18, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

@BethGriggs Also, it looks like GitHub doesn't know your email (for linking to your profile), just FYI if that is not intentional.

Fishrock123 reviewed Jul 18, 2016
View reviewed changes
Comment thread CONTRIBUTING.md Outdated

Fishrock123 Jul 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe See BUILDING.md for more details would be better?

BethGriggs force-pushed the issue-7646-contributing-branch branch from cb9f471 to 66a6c2d Compare July 22, 2016 11:16

BethGriggs commented Jul 22, 2016

Copy link
Copy Markdown
Member Author

Updated PTAL

Trott commented Jul 22, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax commented Jul 27, 2016

Copy link
Copy Markdown
Member

Could you wrap the lines at 80 characters, and maybe use the full URL to the issue in the Fixes: line of the commit message?

LGTM with that, and thanks for the PR.

doc: remove platform assumption from CONTRIBUTING
3e59970 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: nodejs#7646
BethGriggs force-pushed the issue-7646-contributing-branch branch from 66a6c2d to 3e59970 Compare July 27, 2016 12:14

BethGriggs commented Jul 27, 2016

Copy link
Copy Markdown
Member Author

updated, still LGTY?

addaleax commented Jul 27, 2016

Copy link
Copy Markdown
Member

Thanks and yes, I’m going to land this later today if there are no objections/nobody beats me to it.

addaleax commented Jul 27, 2016

Copy link
Copy Markdown
Member

Landed in 868638b, thanks for the contribution! :)

addaleax closed this Jul 27, 2016
addaleax pushed a commit that referenced this pull request Jul 27, 2016
doc: remove platform assumption from CONTRIBUTING
868638b 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
doc: remove platform assumption from CONTRIBUTING
14a0c31 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig mentioned this pull request Aug 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
doc: remove platform assumption from CONTRIBUTING
ba6982f 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
doc: remove platform assumption from CONTRIBUTING
c2dce10 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
doc: remove platform assumption from CONTRIBUTING
80206ff 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
doc: remove platform assumption from CONTRIBUTING
d759d4e 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
BethGriggs deleted the issue-7646-contributing-branch branch February 21, 2018 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md assumes UNIX-like OS

7 participants

Back | FazBrowse Home | New Git URL