FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add imyller to collaborators by imyller · Pull Request #8530 · nodejs/node · GitHub

/ node Public

doc: add imyller to collaborators - #8530

Closed
imyller wants to merge 1 commit into
nodejs:masterfrom
imyller:collab-pr
ConversationCommits (1)ChecksFiles changed
Closed

doc: add imyller to collaborators#8530
imyller wants to merge 1 commit into
nodejs:masterfrom
imyller:collab-pr

Conversation

imyller commented Sep 14, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

doc: add imyller to collaborators
b73dc9d 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 14, 2016

Trott commented Sep 14, 2016

Copy link
Copy Markdown
Member

LGTM

imyller commented Sep 14, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/4042/

lpinca commented Sep 14, 2016

Copy link
Copy Markdown
Member

LGTM

thefourtheye commented Sep 14, 2016

Copy link
Copy Markdown
Contributor

@imyller Please make sure that you follow the guidelines given in the COLLABORATOR_GUIDE while landing the commits.

thefourtheye commented Sep 14, 2016

Copy link
Copy Markdown
Contributor

LGTM and welcome :-)

imyller added a commit that referenced this pull request Sep 14, 2016
doc: add imyller to collaborators
2804518 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

imyller commented Sep 14, 2016

Copy link
Copy Markdown
Member Author

Landed in 2804518

imyller closed this Sep 14, 2016

jbergstroem commented Sep 14, 2016

Copy link
Copy Markdown
Member

🎉!

Trott commented Sep 16, 2016

Copy link
Copy Markdown
Member

@imyller is involved in embedded technologies. He maintains this: https://github.com/imyller/meta-nodejs So, he's all about cross-compiling and so on.

Not sure who it might be useful to connect him with about this stuff, but was wondering specifically about @nodejs/build and/or @nodejs/hardware...

MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
doc: add imyller to collaborators
eb147e2 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
doc: add imyller to collaborators
8f5df1d 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
doc: add imyller to collaborators
c96618f 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
doc: add imyller to collaborators
8a8c790 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
doc: add imyller to collaborators
5ff1fc7 
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL