FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix util.deprecate() example by evanlucas · Pull Request #7674 · nodejs/node · GitHub

/ node Public

doc: fix util.deprecate() example - #7674

Merged
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:utildocs
Jul 13, 2016
Merged

doc: fix util.deprecate() example#7674
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:utildocs

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The arguments object is not created for arrow functions so the example
was incorrect.

nodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Jul 12, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

cjihrig commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor Author

The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: nodejs#7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas closed this Jul 13, 2016
evanlucas deleted the utildocs branch July 13, 2016 12:53

Copy link
Copy Markdown
Contributor Author

Landed in bc7b719. Thanks!

evanlucas merged commit bc7b719 into nodejs:master Jul 13, 2016
evanlucas added a commit that referenced this pull request Jul 15, 2016
The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: #7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: #7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: #7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: #7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: #7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL