FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: no /safeseh for ml64.exe by indutny · Pull Request #7759 · nodejs/node · GitHub

/ node Public

deps: no /safeseh for ml64.exe - #7759

Closed
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:fix/gh-7427
ConversationCommits (1)ChecksFiles changed
Closed

deps: no /safeseh for ml64.exe#7759
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:fix/gh-7427

Conversation

indutny commented Jul 16, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

ml64.exe doesn't support /safeseh option. Do not attempt to use it
if target_arch=="x64".

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx

nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Jul 16, 2016

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

cc @bnoordhuis @piscisaureus

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

cc @nodejs/collaborators @nodejs/platform-windows

indutny mentioned this pull request Jul 16, 2016
Closed
4 tasks

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3309/

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

I wonder how CI has passed for #7427 ...

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

Updated CI: https://ci.nodejs.org/job/node-test-pull-request/3310/

deps: no /safeseh for ml64.exe
2598841 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

Blargh, one more CI: https://ci.nodejs.org/job/node-test-pull-request/3311/

mscdex added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Jul 16, 2016

indutny commented Jul 16, 2016

Copy link
Copy Markdown
Member Author

CI is green.

bnoordhuis commented Jul 16, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments

eljefedelrodeodeljefe commented Jul 16, 2016

Copy link
Copy Markdown
Contributor

LGTM

JungMinu commented Jul 16, 2016

Copy link
Copy Markdown
Member

LGTM

indutny commented Jul 17, 2016

Copy link
Copy Markdown
Member Author

Landed in d4debb9, thank you everyone!

indutny closed this Jul 17, 2016
indutny deleted the fix/gh-7427 branch July 17, 2016 05:05
indutny added a commit that referenced this pull request Jul 17, 2016
deps: no /safeseh for ml64.exe
d4debb9 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
deps: no /safeseh for ml64.exe
3bd40ff 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas mentioned this pull request Jul 19, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
deps: no /safeseh for ml64.exe
939cf6d 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
indutny added a commit to indutny/io.js that referenced this pull request Sep 3, 2016
deps: no /safeseh for ml64.exe
c65c9d7 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: nodejs#7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 4, 2016
deps: no /safeseh for ml64.exe
09099ab 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
deps: no /safeseh for ml64.exe
83f0544 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
deps: no /safeseh for ml64.exe
ab742e9 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
deps: no /safeseh for ml64.exe
9ddc615 
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL