@mcollina i could try to build it in the next two three days. What's the deadline for this task?

Thanks @piccoloaiutante @orangemocha for reviewing, all your changes are in.

@piccoloaiutante it would be great if you could attempt a build, but I'll leave that decision to the @nodejs/platform-windows team on how to test this (I have no idea, but I would love to see this happening).

@mcollina ok i'm downloading VS2013 to build six project because i'm currently unable to build it with my vs2015.
I hope to get it build by tomorrow :-)

@mcollina this also needs to be added commented in nodemsi.wixproj, similar to https://github.com/nodejs/node/pull/2569/files .

@piccoloaiutante note that to build with VS2015 you need WiX 3.10. If you find issues with it, please report.

@joaocgreis i had issue with my vs2015 professional update 1 on Windows 10. After having installed WiX 3.10.2.2516 i cannot build node WiX project because it seems that wcautil.h referenced in custom_action.cc is missing.

Do you have any suggestion? Should i rollback to vs2013?

@joaocgreis I've added the nodemsi.wixproj stuff.

@piccoloaiutante I have the same issue, anyone has a fix?

@felixfbecker yes i solved it downloading WiX binaries and sources and adding their path to the custom_actions cpp project 'VC++ Directories' tab:

I still have problem during compilation time specifically for it-IT language. That's the output:

Possibly it's my bad, any idea how to fix those?

i fixed that problem @mcollina but then it seems i found some limit in WiX installer.

and this seems related to WiX libraries, as reported here:
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/localized-variable-unknown-for-fr-FR-it-IT-and-some-other-cultures-td7585859.html

@piccoloaiutante maybe you can send those translation to upstream at wix (see #2569 (comment))?

@mcollina where are we at on this?

I think it's blocked on Wix. Is the best course of action to submit a PR to add Italian to https://github.com/wixtoolset/wix3/tree/develop/src/ext/UtilExtension/wixlib?

Sorry i missed it. Let me send the PR to WiX and see if it gets accepted.

PR for italian translation for Wix has been submitted. I hope they'll evaluate it soon..

wixtoolset/wix3#366

PR has been merged. I hope it gets its way into WiX weekly release so I can use it for building italian nodejs installer next week.

Bad news, it seems that the code merged won't be released till next version of visual studio is released.

I hope they will make a weekly release as they have done in June.

wixtoolset/wix3#366

In the meantime i suggest to go on and send PR for the language that we need so we can have them in the next version of Wix.

One temporary solution that i could try is to build my own version of wix, but that seems pretty challenging..

I finally got it working :)

@fhemberger I think it's enabled: https://github.com/mcollina/node/blob/148f23c10f5f7c97030d27256c7a7a5510749716/tools/msvs/msi/nodemsi.wixproj#L59.

@mcollina No, the actual msi creation process is still disabled:
https://github.com/mcollina/node/blob/148f23c10f5f7c97030d27256c7a7a5510749716/tools/msvs/msi/nodemsi.wixproj#L79

Merged in as c01d61a

@mcollina Great, thanks! Can we land #2569 as well?

@fhemberger can't really tell. I think so, but I know nothing about Chinese :(.

@mcollina Well, regarding the content, there are several LGTMs from nodejs-cn.

@mcollina I am landing this on v4.x-staging. Would you be able to build and test that things are not weird?

@thealphanerd not really, @piccoloaiutante will do it :)

@thealphanerd as far as I remember, the translated installers were not enabled. Are you enabling them in the next release?

@mcollina I was unaware of that... just working on general backporting 💃

does this need to be enabled in our release process? Want to make an issue on build?

@thealphanerd I'm not really 100% of what that takes @piccoloaiutante did most of the windows-specific stuff. He is also looking to help on build nodejs/build#495.
I will let him drive this.

@thealphanerd enabling build for it-IT in in nodemsi.wixproj i was able to build this PR out of v4.x-staging. Do you need anything else?

@thealphanerd don't forget that in order to build it you need to install the weekly build of wixtoolset http://wixtoolset.org/releases/v3-11-0-906/ where my PR for WiX has been included.

thanks for the confirmation, that was all I needed

On Mon, Oct 3, 2016, 8:45 AM Michele Capra notifications@github.com wrote:

@thealphanerd https://github.com/TheAlphaNerd don't forget that in
order to build it you need to install the weekly build of wixtoolset
http://wixtoolset.org/releases/v3-11-0-906/ where my PR for WiX has been
included.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4647 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVwGPq_0veNa_IWjD-OrRXqBWBi7Eks5qwPkEgaJpZM4HDGdc
.