FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

cluster: remove bind() and self by cjihrig · Pull Request #7710 · nodejs/node · GitHub

/ node Public

cluster: remove bind() and self - #7710

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:self
Jul 15, 2016
ConversationCommits (1)ChecksFiles changed
Merged

cluster: remove bind() and self#7710
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:self

Conversation

cjihrig commented Jul 13, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

cluster

Description of change

This commit removes the use of self and bind() from the cluster module in favor of arrow functions.

nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Jul 13, 2016

cjihrig commented Jul 14, 2016

Copy link
Copy Markdown
Contributor Author

R= @santigimeno ?

targos commented Jul 14, 2016

Copy link
Copy Markdown
Member

LGTM

santigimeno commented Jul 14, 2016

Copy link
Copy Markdown
Member

LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/3295/

JungMinu commented Jul 15, 2016

Copy link
Copy Markdown
Member

LGTM

cluster: remove bind() and self
45367a2 
This commit removes the use of self and bind() from the cluster
module in favor of arrow functions.

PR-URL: nodejs#7710
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
cjihrig merged commit 45367a2 into nodejs:master Jul 15, 2016
cjihrig deleted the self branch July 15, 2016 14:05
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
cluster: remove bind() and self
a855b30 
This commit removes the use of self and bind() from the cluster
module in favor of arrow functions.

PR-URL: #7710
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas mentioned this pull request Jul 19, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
cluster: remove bind() and self
f574bd4 
This commit removes the use of self and bind() from the cluster
module in favor of arrow functions.

PR-URL: #7710
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@cjihrig I've backported this to v4.x. Do you know if there are any performance issues with arrow function in V8 4.8?

/cc @nodejs/v8

MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
cluster: remove bind() and self
f62f99d 
This commit removes the use of self and bind() from the cluster
module in favor of arrow functions.

PR-URL: #7710
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

cjihrig commented Sep 30, 2016

Copy link
Copy Markdown
Contributor Author

Nothing comes to mind. I don't recall the project ever holding back on the use of arrow functions for performance reasons.

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@cjihrig sgtm. Just being extraaaa careful 😄

ofrobots commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

What is the motivation to backport to v4.x?

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@ofrobots trying to keep the delta in cluster as small as possible. This is only to staging and can easily be removed if you don't think it should land.

rvagg pushed a commit that referenced this pull request Oct 18, 2016
cluster: remove bind() and self
af16339 
This commit removes the use of self and bind() from the cluster
module in favor of arrow functions.

PR-URL: #7710
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
cluster: remove bind() and self
227db0a 
This commit removes the use of self and bind() from the cluster
module in favor of arrow functions.

PR-URL: #7710
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cluster Issues and PRs related to the cluster subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL