FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: backport 2bcbe2f from V8 upstream by ofrobots · Pull Request #7814 · nodejs/node · GitHub

/ node Public

deps: backport 2bcbe2f from V8 upstream - #7814

Merged
ofrobots merged 1 commit into
nodejs:v6.xfrom
ofrobots:perf-buffering-6.x
Jul 29, 2016
ConversationCommits (1)ChecksFiles changed
Merged

deps: backport 2bcbe2f from V8 upstream#7814
ofrobots merged 1 commit into
nodejs:v6.xfrom
ofrobots:perf-buffering-6.x

Conversation

ofrobots commented Jul 21, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{#36788}

Note that this is not needed on master as V8 5.1 already contains this fix.
R=@nodejs/v8

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/3362/

ofrobots added v8 engine Issues and PRs related to the V8 dependency. lts-watch-v4.x labels Jul 21, 2016
mscdex added the v6.x label Jul 21, 2016

bnoordhuis commented Jul 21, 2016

Copy link
Copy Markdown
Member

LGTM but out of curiosity, is there a reason you opted for line buffering instead of no buffering? It seems the output is line oriented anyways so libc's newline scanning just adds unnecessary, if minimal, overhead.

ofrobots commented Jul 21, 2016

Copy link
Copy Markdown
Contributor Author

No strong reason other than to avoid any file watchers from observing partially complete lines. The output is indeed line oriented today; but the code may change in the future. The new line scanning is going to be negligible cost.

ofrobots force-pushed the perf-buffering-6.x branch from bab39d4 to bf3d4b2 Compare July 26, 2016 00:32

ofrobots commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

Rebased, added a V8 patch-level bump. Relaunched CI: https://ci.nodejs.org/job/node-test-pull-request/3413/.

ofrobots commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/244/. I think the Power BE machine has infrastructure issues. The rest are green.

ofrobots commented Jul 29, 2016

Copy link
Copy Markdown
Contributor Author

@nodejs/release: this is ready for landing onto v6.x. Should I do that myself?

evanlucas commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

works for me :]

deps: backport 2bcbe2f from V8 upstream
e82e804 
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{nodejs#36788}

PR-URL: nodejs#7814
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
ofrobots force-pushed the perf-buffering-6.x branch from bf3d4b2 to e82e804 Compare July 29, 2016 17:51
ofrobots merged commit e82e804 into nodejs:v6.x Jul 29, 2016

ofrobots commented Jul 29, 2016

Copy link
Copy Markdown
Contributor Author

Thanks. Landed on v6.x as e82e804.

cjihrig mentioned this pull request Aug 11, 2016
Merged
ofrobots deleted the perf-buffering-6.x branch August 17, 2016 17:58
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Aug 18, 2016
deps: backport 2bcbe2f from V8 upstream
228ab33 
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{#36788}

PR-URL: nodejs/node#7814
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
deps: backport 2bcbe2f from V8 upstream
004d665 
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{#36788}

PR-URL: #7814
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
deps: backport 2bcbe2f from V8 upstream
9569501 
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{#36788}

PR-URL: #7814
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
deps: backport 2bcbe2f from V8 upstream
52cba41 
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{#36788}

PR-URL: #7814
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Nov 9, 2016
deps: backport 2bcbe2f from V8 upstream
ecebfae 
Excessive buffering of perf map files in V8 could cause profiles
to be missing symbols at times.

Original commit message:
  switch perf and ll_prof loggers to line buffering

  BUG=v8:5015
  R=jarin@chromium.org,yangguo@chromium.org

  Review-Url: https://codereview.chromium.org/2041243002
  Cr-Commit-Position: refs/heads/master@{#36788}

PR-URL: nodejs/node#7814
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL