FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

adding test for _stream.writable `ended` state by italoacasas · Pull Request #8778 · nodejs/node · GitHub

/ node Public

adding test for _stream.writable ended state - #8778

Closed
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/stream_writable_ended_state
ConversationCommits (1)ChecksFiles changed
Closed

adding test for _stream.writable ended state#8778
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/stream_writable_ended_state

Conversation

italoacasas commented Sep 26, 2016

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Adding tests for stream._writableState.ended

Issue related: #8686

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 26, 2016
mscdex added the stream Issues and PRs related to the stream subsystem. label Sep 26, 2016
mcollina self-assigned this Sep 26, 2016
jasnell reviewed Sep 27, 2016
View reviewed changes
Comment thread test/parallel/test-stream-writable-ended-state.js Outdated

jasnell Sep 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The callback here should be wrapped in a common.mustCall() in order to verify that it actually does get called.

mcollina commented Sep 29, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell approved these changes Sep 30, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with green CI

jasnell commented Sep 30, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4331/

mcollina pushed a commit that referenced this pull request Sep 30, 2016
test: stream writable ended state
5e6bd84 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

mcollina commented Sep 30, 2016

Copy link
Copy Markdown
Member

CI failures were not related.
Landed in 5e6bd84

mcollina closed this Sep 30, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
test: stream writable ended state
2ecd3b5 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 6, 2016
test: stream writable ended state
89f2221 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
test: stream writable ended state
81e60f4 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
test: stream writable ended state
4fa0fc5 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
test: stream writable ended state
5e5d034 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
test: stream writable ended state
c543f4a 
PR-URL: #8778
Ref: #8686
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Oct 26, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

mcollina

Labels

stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL