FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky test/fs-read-buffer-tostring-fail by Trott · Pull Request #7575 · nodejs/node · GitHub

/ node Public

test: fix flaky test/fs-read-buffer-tostring-fail - #7575

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:90
ConversationCommits (2)ChecksFiles changed
Closed

test: fix flaky test/fs-read-buffer-tostring-fail#7575
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:90

Conversation

Trott commented Jul 7, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

Description of change

The test is memory intensive and times out occasionally on Raspberry Pi
devices in CI. Successful test runs take about 90 seconds, but the
devices time out after 120 seconds. That's not a lot of headroom. So
let's skip the test on devices that have only modest amounts of memory.

Trott added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. labels Jul 7, 2016
Trott mentioned this pull request Jul 7, 2016
Closed
test: fix flaky test/fs-read-buffer-tostring-fail
01db593 
The test is memory intensive and times out occasionally on Raspberry Pi
devices in CI. Successful test runs take about 90 seconds, but the
devices time out after 120 seconds. That's not a lot of headroom. So
let's skip the test on devices that have only modest amounts of memory.

Fixes: nodejs#7042
mscdex reviewed Jul 7, 2016
View reviewed changes
Comment thread test/parallel/test-fs-read-buffer-tostring-fail.js Outdated

const common = require('../common');

const skipMessage = 'intensive toString tests due to memory confinements';

mscdex Jul 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doesn't there need to be a header here or something, like the other tests that have a similar skip message?

Trott Jul 7, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure what you mean. Here's another example:

node/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-at-max.js

Lines 11 to 15 in b10ee9d

const skipMessage = 'intensive toString tests due to memory confinements';
if (!common.enoughTestMem) {
common.skip(skipMessage);
return;
}

And here's what this test pass when it skips:

1..0 # Skipped: intensive toString tests due to memory confinements

Trott Jul 7, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I guess I'll run CI and see what happens on the Raspberry Pi devices...

mscdex Jul 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nevermind, I didn't realize .skip() was adding the necessary header.

Trott commented Jul 7, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3197/

Trott commented Jul 7, 2016

Copy link
Copy Markdown
Member Author

Only CI failure is known FreeBSD flaky test. (How is everyone not LGTM-ing the crud out of #7555 to get that fixed?)

Trott commented Jul 7, 2016

Copy link
Copy Markdown
Member Author

Raspberry Pis in CI seem to skip correctly:

ok 45 parallel/test-fs-read-buffer-tostring-fail # skip intensive toString tests due to memory confinements
  ---
  duration_ms: 2.53

That output format matches other skipped tests, such as:

ok 64 parallel/test-http-full-response # skip problem spawning `ab`.
  ---
  duration_ms: 2.855

Meanwhile, the test is not skipped on (for example) OS X:

ok 322 parallel/test-fs-read-buffer-tostring-fail
  ---
  duration_ms: 2.336

I think this is good to go.

rvagg commented Jul 7, 2016

Copy link
Copy Markdown
Member

lgtm, seems like the sensible way to go

evanlucas commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

lgtm

santigimeno commented Jul 7, 2016

Copy link
Copy Markdown
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jul 9, 2016
test: fix flaky test-fs-read-buffer-tostring-fail
b9b49ee 
The test is memory intensive and times out occasionally on Raspberry Pi
devices in CI. Successful test runs take about 90 seconds, but the
devices time out after 120 seconds. That's not a lot of headroom. So
let's skip the test on devices that have only modest amounts of memory.

Fixes: nodejs#7042
PR-URL: nodejs#7575
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Trott commented Jul 9, 2016

Copy link
Copy Markdown
Member Author

Landed in b9b49ee

Trott closed this Jul 9, 2016
MylesBorins mentioned this pull request Jul 11, 2016
Closed

MylesBorins commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

@Trott lts?

Trott commented Jul 12, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd Yes if it lands cleanly and CI passes.

evanlucas pushed a commit that referenced this pull request Jul 13, 2016
test: fix flaky test-fs-read-buffer-tostring-fail
8e50413 
The test is memory intensive and times out occasionally on Raspberry Pi
devices in CI. Successful test runs take about 90 seconds, but the
devices time out after 120 seconds. That's not a lot of headroom. So
let's skip the test on devices that have only modest amounts of memory.

Fixes: #7042
PR-URL: #7575
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
evanlucas mentioned this pull request Jul 18, 2016
Merged
seishun mentioned this pull request Nov 18, 2016
Merged
2 tasks
Trott deleted the 90 branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL