test: cleanup IIFE tests - #7694
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: nodejs#7694 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: #7694 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup such as use of strictEqual() and common.mustCall() is also included. PR-URL: #7694 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
@cjihrig this is not landing cleanly on v4.x. Please feel free to manually backport |
Sorry, something went wrong.
|
Caveat emptor: this pull request introduces bugs in at least test/parallel/test-crypto-authenticated.js - the removal of the IIFE make the return statements stop the test instead of just skipping the subtest. See the discussion in #9032. |
Sorry, something went wrong.
|
I'm reviewing all the tests in this PR and will submit a follow up that fixes any such bugs. |
Sorry, something went wrong.
|
I see that @bnoordhuis covered test/parallel/test-crypto-authenticated.js in #9032. I've gone through all the tests in this PR, and that seems to be the only one that needs to be updated. |
Sorry, something went wrong.
Checklist
Affected core subsystem(s)
test
Description of change
A number of test files use IIFEs to separate distinct tests from each other in the same file. The project has been moving toward using block scopes and let/const in favor of IIFEs. This commit moves IIFE tests to block scopes. Some additional cleanup of these tests such as the use of assert.strictEqual() and common.mustCall() is also included.
R= @nodejs/testing