FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Correcting misspelling by vitaly-t · Pull Request #7797 · nodejs/node · GitHub

/ node Public

Correcting misspelling - #7797

Closed
vitaly-t wants to merge 1 commit into
nodejs:masterfrom
vitaly-t:patch-1
Closed

Correcting misspelling#7797
vitaly-t wants to merge 1 commit into
nodejs:masterfrom
vitaly-t:patch-1

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Changing stringp to string.

Changing `stringp` to `string`.
nodejs-github-bot added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Jul 19, 2016

cjihrig commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

LGTM

3 similar comments

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown
Contributor

Thanks! Landed in 74f0943.

silverwind closed this Jul 20, 2016
silverwind pushed a commit that referenced this pull request Jul 20, 2016
Changing `stringp` to `string`.

PR-URL: #7797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Copy link
Copy Markdown
Contributor

The issue was introduced in 1b6a468, which doesn't seem to have landed on LTS yet.

evanlucas pushed a commit that referenced this pull request Jul 21, 2016
Changing `stringp` to `string`.

PR-URL: #7797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL