FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix detached child stdio example by cjihrig · Pull Request #7540 · nodejs/node · GitHub

/ node Public

doc: fix detached child stdio example - #7540

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:7269
Jul 6, 2016
Merged

doc: fix detached child stdio example#7540
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:7269

Conversation

cjihrig commented Jul 5, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The example uses ['ignore'], where 'ignore' is intended. This commit drops the extra braces.

Fixes: #7269

nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jul 5, 2016

addaleax commented Jul 5, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

jasnell commented Jul 5, 2016

Copy link
Copy Markdown
Member

LGTM

The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: nodejs#7269
PR-URL: nodejs#7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig merged commit 5a571a5 into nodejs:master Jul 6, 2016
cjihrig deleted the 7269 branch July 6, 2016 16:02
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 12, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
The example changed by this commit uses ['ignore'] where
'ignore' is intended.

Fixes: #7269
PR-URL: #7540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL