FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

zlib: name every function by solebox · Pull Request #9389 · nodejs/node · GitHub

/ node Public

zlib: name every function - #9389

Closed
solebox wants to merge 2 commits into
nodejs:masterfrom
solebox:zlib
ConversationCommits (2)ChecksFiles changed
Closed

zlib: name every function#9389
solebox wants to merge 2 commits into
nodejs:masterfrom
solebox:zlib

Conversation

solebox commented Oct 31, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • [ v] make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • [ v] commit message follows commit guidelines
Affected core subsystem(s)

zlib

Description of change

named handlers

Ref: #8913

nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Oct 31, 2016
jasnell reviewed Nov 2, 2016
View reviewed changes
Comment thread lib/zlib.js Outdated
var self = this;
this._hadError = false;
this._handle.onerror = function(message, errno) {
this._handle.onerror = (message, errno) => {

jasnell Nov 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wouldn't change this one to an arrow function. There's really no point in doing so here. I would just add a name to the existing function

solebox commented Nov 3, 2016

Copy link
Copy Markdown
Contributor Author

no CI?

silverwind commented Nov 3, 2016

Copy link
Copy Markdown
Contributor

Here you go: https://ci.nodejs.org/job/node-test-pull-request/4774/

solebox commented Nov 8, 2016

Copy link
Copy Markdown
Contributor Author

@silverwind boink?

mhdawson approved these changes Nov 8, 2016
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented Nov 8, 2016

Copy link
Copy Markdown
Member

Failure on arm in CI looks un-related so should be good to land

mhdawson commented Nov 8, 2016

Copy link
Copy Markdown
Member

Landed as 77ec310

mhdawson closed this Nov 8, 2016
mhdawson pushed a commit that referenced this pull request Nov 8, 2016
zlib: name every function Ref: #8913
77ec310 
PR-URL: #9389
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Trott commented Nov 9, 2016

Copy link
Copy Markdown
Member

This has broken linting on CI because it violates a lint rule that landed since CI was run for it 5 days ago. :-(

Trott mentioned this pull request Nov 9, 2016
Closed
2 tasks

Trott commented Nov 9, 2016

Copy link
Copy Markdown
Member

The fix is at #9524.

solebox deleted the zlib branch November 19, 2016 15:37
addaleax pushed a commit that referenced this pull request Nov 22, 2016
zlib: name every function Ref: #8913
841a2c4 
PR-URL: #9389
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2017
MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
silverwind silverwind approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL