zlib: fix linting recently-introduced lint error - #9524
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Because CI will fail until this gets fixed and is such a minor change, I would advocate that this not wait the usual 48 hours but land sooner. |
Sorry, something went wrong.
addaleax
approved these changes
Nov 9, 2016
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM and feel free to jump straight to landing this as far as I am concerned
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Remove unnecessary named function. V8 will do a better job inferring the name from the assignment to a property. The current formulation does not pass linting.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 9, 2016
Remove unnecessary named function. V8 will do a better job inferring the name from the assignment to a property. The current formulation does not pass linting. PR-URL: nodejs#9524 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
Remove unnecessary named function. V8 will do a better job inferring the name from the assignment to a property. The current formulation does not pass linting. PR-URL: #9524 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
zlib
Description of change
Remove unnecessary named function. V8 will do a better job inferring the
name from the assignment to a property. The current formulation does not
pass linting.
Refs: #9389 (comment)