docs: refer to "squash" in help screen for git node land - #1108
Merged
aduh95 merged 1 commit intoJul 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1108 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 45 45
Lines 7003 7003
=======================================
Hits 4519 4519
Misses 2484 2484 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Renegade334
reviewed
Jul 1, 2026
Comment thread
components/git/land.js
Outdated
Renegade334
approved these changes
Jul 1, 2026
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Copy link
Copy Markdown
Member
Author
|
Force push to squash as there was a linter error when I accepted @Renegade334's suggested change related to the Co-authored-by line that was added. |
Sorry, something went wrong.
Renegade334
approved these changes
Jul 1, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is my first contribution to NCU I'll note that npm run test-all as documented in the contributing guide doesn't seem to be valid. I have run npm test on this though. Based on the fact it looks like the target was removed in #670 I'll submit a follow on PR to remove that step from the guide.
This change is because I was looking for the option on git node land to squash commits when landing nodejs/node#64193 (which I was pretty sure I'd used on the past) but it doesn't have squash in the help screen as it's named fixupAll and this will allow git node land --help | grep squash to find it. I may also add a reference to this as a recommendation in the main node collaborator guide if people thing that's appropriate.