docs: remove "npm test-all" from CONTRIBUTING.md" - #1109
Merged
Renegade334 merged 1 commit intoJul 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Copy link
Copy Markdown
Member
Author
|
FYI @aduh95 as the author of the original PR. I don't seem to have permissions to assign you as an explicit reviewer. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1109 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 45 45
Lines 7003 7003
=======================================
Hits 4519 4519
Misses 2484 2484 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
aduh95
approved these changes
Jul 1, 2026
Renegade334
approved these changes
Jul 1, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted during #1108
npm test-all seems to have been removed from package.json in https://github.com/nodejs/node-core-utils/pull/670/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 but was left in the documentation. If something else should replace it then let me know, otherwise removing it and leaving npm test in there seems reasonable.