fix: ignore codecov check suite - #838
Conversation
Sorry, something went wrong.
| if (app && app.slug === 'dependabot') { | ||
| // Ignore Dependabot check suites. They are expected to show up | ||
| if (app && IGNORED_CHECK_SLUGS.includes(app.slug)) { | ||
| // Ignore app check suites. They are expected to show up |
There was a problem hiding this comment.
| // Ignore app check suites. They are expected to show up | |
| // Ignore GitHub Apps check suites. They are expected to show up |
That makes me think; should we filter only status for checks from {"slug":"github-actions"} instead of trying to maintain a list of Apps we have installed?
Sorry, something went wrong.
There was a problem hiding this comment.
Might be fine as long as we don't require checks from other apps :)
Sorry, something went wrong.
There was a problem hiding this comment.
I think just ignoring dependabot and codecov is fine for now, but if the project installs more apps, maybe then ignore all apps.
Sorry, something went wrong.
There was a problem hiding this comment.
Well in this case, we should have the comment align with what the code is doing
| // Ignore app check suites. They are expected to show up | |
| // Ignore Dependabot and Codecov check suites. They are expected to show up |
Sorry, something went wrong.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ref https://openjs-foundation.slack.com/archives/C019MGJQ8RH/p1722871958000979