FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: redirect Corepack documentation page by aduh95 · Pull Request #7643 · nodejs/nodejs.org · GitHub

/ nodejs.org Public

meta: redirect Corepack documentation page - #7643

Closed
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:corepack-redirect
ConversationCommits (1)ChecksFiles changed
Closed

meta: redirect Corepack documentation page#7643
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:corepack-redirect

Conversation

aduh95 commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Description

To address nodejs/node#57663 (comment).

This page is being removed, however it's quite cheap for us not to break the existing links.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings April 11, 2025 17:17
aduh95 requested a review from a team as a code owner April 11, 2025 17:17
Copilot AI reviewed Apr 11, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • apps/site/redirects.json: Language not supported

vercel Bot commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 11, 2025 5:18pm

aduh95 mentioned this pull request Apr 11, 2025
Merged
avivkeller reviewed Apr 11, 2025
View reviewed changes
Comment thread apps/site/redirects.json
trivikr previously requested changes Apr 11, 2025
View reviewed changes
Comment thread apps/site/redirects.json
flakey5 requested changes Apr 11, 2025
View reviewed changes

flakey5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The website doesn't serve /api or /docs, so these redirects wouldn't be functional. These would either need to be set up in Cloudflare or in the release worker

AugustinMauroy commented Apr 11, 2025

Copy link
Copy Markdown
Member

@flakey5 if you open an issue/pr on right repo we can close this one

trivikr commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

if you open an issue/pr on right repo we can close this one

I think we shouldn't introduce the redirect till Corepack is removed from Node.js latest, which will happen in 25.0.0 in October 2025.

I've called it out in #7643 (comment)

trivikr self-requested a review April 14, 2025 01:54
trivikr dismissed their stale review April 14, 2025 01:57

Antoine and I discussed over OpenJS Slack channel #nodejs-corepack and realized that it should be okay to add redirect for corepack latest after 24.0.0 launch since:

  • Only the way corepack is distributed is changing. The branding and functionality remains the same.
  • The decision to remove corepack was taken before v24.0.0. The redirect can be considered as semver-major.

trivikr commented Apr 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

These would either need to be set up in Cloudflare or in the release worker

The next action is to setup redirect in Cloudflare or in the release worker, and close this PR.

trivikr mentioned this pull request Apr 14, 2025
Closed

avivkeller commented Apr 14, 2025

Copy link
Copy Markdown
Member

I'm closing this PR since, no matter what happens, this cannot merge in this repository, however, feel free to continue discussing the future in this PR, if needed.

avivkeller closed this Apr 14, 2025

avivkeller commented Apr 14, 2025

Copy link
Copy Markdown
Member

Also, for posterity,

@trivikr was referencing https://openjs-foundation.slack.com/archives/C06LTLUK9NZ/p1744489893809369

aduh95 mentioned this pull request Apr 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller left review comments
bjohansebas bjohansebas left review comments
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
flakey5 flakey5 requested changes
trivikr Awaiting requested review from trivikr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL