BUG: Fix small issues found with pytest-leaks - #18670
charris merged 1 commit into
Conversation
Sorry, something went wrong.
|
I had not done a good pytest-leaks in a while. I still got one running (since I restarted after I found these), so some small things might still crop up, although it doesn't have stop merging this. |
Sorry, something went wrong.
There was a problem hiding this comment.
This is causing problems on windows. Try data.tofile(tmp). Windows only allows a single process to access an open file and I suspect that is the problem.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks! Well, I tried with TemporaryDirectory and just fixed the actual filename as a file inside that directory... That seems to work fine, lets see what windows thinks.
Maybe using tmp directly is nicer, but then I have to deal with seek(0) also...
Sorry, something went wrong.
None of these are particularly worrying as they either usually only leak reference (and not memory) or appear in rare or almost impossible error-paths, or are limited to the tests. Unfortunately, this PR will not apply to 1.20.x, due to small changes in the overrides.
|
Thanks Sebastian. |
Sorry, something went wrong.
None of these are particularly worrying as they either usually only leak reference (and not memory) or appear in rare or almost impossible error-paths, or are limited to the tests. Unfortunately, this PR will not apply to 1.20.x, due to small changes in the overrides. Backport of numpygh-18670 (with two small differences)
None of these are particularly worrying as they either usually only
leak reference (and not memory) or appear in rare or almost impossible
error-paths, or are limited to the tests.
Unfortunately, this PR will not apply to 1.20.x, due to small changes
in the overrides.
The first override fix has to be done equivalently to the second one for backporting. I can open a backport PR once this is merged.