BUG: Fix small issues found with pytest-leaks - #18671
Merged
charris merged 1 commit intoMar 24, 2021
Merged
charris merged 1 commit into
charris merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
None of these are particularly worrying as they either usually only leak reference (and not memory) or appear in rare or almost impossible error-paths, or are limited to the tests. Unfortunately, this PR will not apply to 1.20.x, due to small changes in the overrides. Backport of numpygh-18670 (with two small differences)
seberg
commented
Mar 23, 2021
Comment thread
numpy/core/src/multiarray/arrayfunction_override.c
| "The `like` argument must be an array-like that " | ||
| "implements the `__array_function__` protocol."); | ||
| } | ||
| Py_DECREF(tmp_has_override); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is the larger difference. The code path looks different on main. This is much like the diff just above.
Sorry, something went wrong.
seberg
commented
Mar 23, 2021
Comment thread
numpy/core/src/multiarray/multiarraymodule.c
| array_function_result = array_implement_c_array_function_creation( | ||
| "fromstring", args, keywds); | ||
| if (array_function_result != Py_NotImplemented) { | ||
| Py_XDECREF(descr); |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I had already fixed that in the larger argument parsing, so this was also not part of the initial PR.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks Sebastian. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of gh-18670 (with two small differences)
None of these are particularly worrying as they either usually only
leak reference (and not memory) or appear in rare or almost impossible
error-paths, or are limited to the tests.
Unfortunately, this PR will not apply to 1.20.x, due to small changes
in the overrides.